1971847 - Add tab group type information to add_tab event

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P2)

Description

[Stephen Thompson [:sthompson]]

The existing tabgroup.add_tab telemetry event tells us when users add a tab(s) to a tab group, but it does not provide any context about the destination tab group.

After bug 1955287, it will be newly possible to add tabs to saved+closed tab groups. After bug 1971231 and bug 1971232, users will have more reasons to add tabs to collapsed tab groups (even though they can do so already).

In order to measure usage of these new features, we should add a new key-value to the existing tabgroup.add_tab event.

Key name: group_type
Type: string
Description: The state of the tab group to which the tab(s) is being added
Expected values:

• expanded: when the destination tab group is not collapsed
• collapsed: when the destination tab group is collapsed
• saved: when the destination tab group is saved and closed (only in session state, not in the tab strip)

Tab groups telemetry document https://docs.google.com/spreadsheets/d/1uHYWfje-PKQCL2RPQIm9eIyXwRUIsSe7a7yA1Mq7FNA/edit?gid=0#gid=0

Comment 2

[Jeremy Swinarton]

Attachment: Bug 1971847: Add tab group type information to add_tab event r?dwalker,sthompson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f3d23e1bf239
https://hg.mozilla.org/integration/autoland/rev/5e13ffbb39f9
Add tab group type information to add_tab event r=sthompson,sessionstore-reviewers,tabbrowser-reviewers

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5e13ffbb39f9