Closed
Bug 1955325
Opened 1 year ago
Closed 1 month ago
Create opacity tokens
Categories
(Toolkit :: Themes, task, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
152 Branch
| Tracking | Status | |
|---|---|---|
| firefox152 | --- | fixed |
People
(Reporter: jules, Assigned: jooliver)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp] [acorntractors])
Attachments
(1 file)
We've noticed a use of similar opacity values around our codebase for disabling and/or deemphasizing elements. Let's take a quick audit and capture these reusable opacity values as tokens.
The patch at bug 1951524 might be related here.
|
||
Comment 2•10 months ago
|
||
This will need some investigation for what specific values we want to add, but should be a part of our push to tokenize more of the app.
Whiteboard: [acorntractors]
|
||
Updated•9 months ago
|
Whiteboard: [acorntractors] → [recomp] [acorntractors]
|
||
Updated•9 months ago
|
|
Assignee | |
Updated•4 months ago
|
Assignee: nobody → jooliver
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•4 months ago
|
||
- Adds scale of primitive opacity tokens
- Adds layer of semantic opacity tokens
- Adds opacity to use-design-tokens stylelint rule
- Fixes occurences of opacity-related stylelint errors (does not account for all ignored files in stylelint rollout)
|
||
Updated•3 months ago
|
Attachment #9541128 -
Attachment description: WIP: Bug 1955325 - add opacity tokens → WIP: Bug 1955325 - add opacity tokens r=#desktop-theme-reviewers
|
|
||
Updated•3 months ago
|
Attachment #9541128 -
Attachment description: WIP: Bug 1955325 - add opacity tokens r=#desktop-theme-reviewers → Bug 1955325 - add opacity tokens r=#desktop-theme-reviewers
|
|
||
Updated•3 months ago
|
Attachment #9541128 -
Attachment description: Bug 1955325 - add opacity tokens r=#desktop-theme-reviewers → WIP: Bug 1955325 - add opacity tokens r=#desktop-theme-reviewers
|
|
||
Updated•3 months ago
|
Attachment #9541128 -
Attachment description: WIP: Bug 1955325 - add opacity tokens r=#desktop-theme-reviewers → Bug 1955325 - add opacity tokens r=#desktop-theme-reviewers
Pushed by jooliver@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/c693398a5a83
https://hg.mozilla.org/integration/autoland/rev/50810d489087
add opacity tokens r=desktop-theme-reviewers,tabbrowser-reviewers,jules,sfoster,nsharpley,dao
|
||
Comment 5•1 month ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox152:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•