Closed Bug 2022977 Opened 6 months ago Closed 4 months ago

Update menu.css so it passes use-design-tokens

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
task

Tracking

(firefox152 fixed)

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox152 --- fixed

People

(Reporter: dwhisman, Assigned: oarnesto)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp][acorntractors])

Attachments

(1 file)

Bug 2022977 - Update `menu.css` to pass use-design-tokens r=desktop-theme-reviewers,dao
48 bytes, text/x-phabricator-request
Details | Review

Update toolkit/themes/shared/menu.css with design tokens so it passes our use-design-tokens stylelint rule.

To see existing violations, run:

./mach lint -l stylelint --skip-rollouts toolkit/themes/shared/menu.css
Assignee: nobody → oarnesto
Status: NEW → ASSIGNED
Attachment #9554309 - Attachment description: WIP: Bug 2022977 - Update `menu.css` to pass use-design-tokens r=#reusable-components-reviewers-rotation → Bug 2022977 - Update `menu.css` to pass use-design-tokens r=#reusable-components-reviewers-rotation
Depends on: 1955325
Pushed by rperta@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6139f848992b https://hg.mozilla.org/integration/autoland/rev/c7243c2abfa7 Revert "Bug 2022977 - Update `menu.css` to pass use-design-tokens r=desktop-theme-reviewers,dao" for causing chrome failures at test_largemenu.html

Backed out for causing chrome failures at test_largemenu.html
Backout link
Push with failures
Failure log(s)

Flags: needinfo?(oarnesto)
Attachment #9554309 - Attachment description: Bug 2022977 - Update `menu.css` to pass use-design-tokens r=#reusable-components-reviewers-rotation → Bug 2022977 - Update menu.css to pass use-design-tokens r=desktop-theme-reviewers,dao
Attachment #9554309 - Attachment description: Bug 2022977 - Update menu.css to pass use-design-tokens r=desktop-theme-reviewers,dao → Bug 2022977 - Update `menu.css` to pass use-design-tokens r=desktop-theme-reviewers,dao
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/35d1e9919485 https://hg.mozilla.org/integration/autoland/rev/d5c067278073 Revert "Bug 2022977 - Update `menu.css` to pass use-design-tokens r=desktop-theme-reviewers,dao" for causing mochitest failures at test_largemenu.html

Backed out for causing mochitests failures at largemenu.html
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_largemenu.html | menu movement (6000, 100) x - got 1554, expected 1553

Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a0feca31876d https://hg.mozilla.org/integration/autoland/rev/9b31cbc28fbd Revert "Bug 2022977 - Update `menu.css` to pass use-design-tokens r=desktop-theme-reviewers,dao" for causing mochitests failures at largemenu.html

Backed out for causing mochitests failures at largemenu.html
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_largemenu.html | open when bottom would overlap bottom - got 1081, expected 1080

https://hg.mozilla.org/mozilla-central/rev/773363dd4e8c

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
Flags: needinfo?(oarnesto)
Blocks: 2046727
No longer blocks: 2046727
Regressions: 2046727
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: