Open Bug 1955344 Opened 10 months ago Updated 4 months ago

Make Places clipboard code depend on BrowserUtils instead of vice versa

Categories

(Toolkit :: Places, task, P3)

Product:
Toolkit
Component:
Places
Platform:
Desktop
All
Type:
task

Tracking

()

People

(Reporter: Gijs, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng])

In bug 1953575 I'm extracting a tiny amount of clipboard helper code to copy a link with a title from Places to BrowserUtils, but BrowserUtils still ends up depending on PlacesUtils for the "guts" of the implementation. Drew quite correctly pointed out that that feels like it's the wrong way around. I agree.

The problem is that PlacesUtils.wrapNode covers quite a few cases, not just copying a single link but also folders, separators, etc., and not just plain text and HTML clipboard flavours but also Mozilla places-specific things.

Moving all of that to BrowserUtils also feels inappropriate. But some of it (e.g. the HTML escaping code) could probably live somewhere else, either BrowserUtils itself or some other non-places-specific venue.

So this bug covers trying to make this dependency relation... less messy.

Severity: -- → N/A
Priority: -- → P3
Whiteboard: [sng]
Blocks: 1984362
You need to log in before you can comment on or make changes to this bug.