1984362 - Share -> "Copy link" for multiselected tabs should copy all the tabs' information

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[:Gijs (he/him)]

The copy link item was added in bug 1953575 for both Linux and at the top of the macOS sharing menu. It should be straightforward to update it to work for multiple tabs.

Comment 1

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #0)

The copy link item was added in bug 1953575 for both Linux and at the top of the macOS sharing menu. It should be straightforward to update it to work for multiple tabs.

Except, of course, paging context from bug 1953575 back in... we don't have good abstractions for clipboard manipulation, and the code is not ideally organized, cf bug 1955344. :-(

Comment 2

[Jeremy Swinarton]

Attachment: Bug 1984362: Support for copying links when more than one tab is selected r?dwalker,sthompson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2e40480df526
https://hg.mozilla.org/integration/autoland/rev/da53243c1e0e
Support for copying links when more than one tab is selected r=sthompson,fluent-reviewers,tabbrowser-reviewers,bolsson,urlbar-reviewers,jteow

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0269b7e981d2
https://hg.mozilla.org/integration/autoland/rev/43631c0dcb67
Revert "Bug 1984362: Support for copying links when more than one tab is selected r=sthompson,fluent-reviewers,tabbrowser-reviewers,bolsson,urlbar-reviewers,jteow" for causing macOS bc crashes on browser_add_search_engine.js.

Comment 5

[Iulian Moraru]

Revert for causing macOS bc crashes on browser_add_search_engine.js.

• Push with failures

• Failure log

• this is also causing these TV failures if you want to take a look before relanding: https://treeherder.mozilla.org/logviewer?job_id=553536461&repo=autoland&task=U21a7LlSTf6Yl3ynV2wF0A.0&lineNumber=2395

• Backout link

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7de39cb25ac7
https://hg.mozilla.org/integration/autoland/rev/5353171c5f22
Support for copying links when more than one tab is selected r=sthompson,fluent-reviewers,tabbrowser-reviewers,bolsson,urlbar-reviewers,jteow

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5353171c5f22