1955672 - Failures in some WPT reftests for font-variant-emoji

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

We're currently failing css/css-fonts/font-variant-emoji-003.html because our heuristics for selecting between color-emoji and monochrome fonts don't entirely match the test expectations.

[Also showing a failure on wpt.fyi for font-variant-emoji-004.html, but that's just an issue of line height/alignment; the expected glyphs are showing up, but one line of the text is vertically shifted slightly. This is probably a result of inconsistencies in font metrics between the various fonts present, such that line-height (or ascent/descent) computes differently, and we should make the test more robust to eliminate this.]

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1955672 - Improve the interaction between font-variant-emoji and Unicode emoji properties during font selection. r=#layout

The existing tests are tweaked to make them more reliable:

(a) Explicit height/line-height is added to avoid spurious discrepances
caused by normal line-height depending on the browser's default fonts.

(b) Variation selectors are added to the reference cases where a glyph
is to be rendered with a different style than its default presentation;
without this, browsers may choose a default font with the "preferred"
presentation over the specified webfont in the reference. With this fix,
the reference files render consistently across Chrome/Firefox/Safari.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1955672 followup - Rename eFontPresentation enum to simply FontPresentation. r=#layout

No change in behavior, just a global rename of the type.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/222e4b7b3b74
Improve the interaction between font-variant-emoji and Unicode emoji properties during font selection. r=layout-reviewers,emilio,dshin
https://hg.mozilla.org/integration/autoland/rev/607af81ae4a2
followup - Rename eFontPresentation enum to simply FontPresentation. r=layout-reviewers,emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/51766 for changes under testing/web-platform/tests

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/222e4b7b3b74
https://hg.mozilla.org/mozilla-central/rev/607af81ae4a2

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot