1956082 - Read from the shared SQL database for enrollments

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, enhancement, P1)

Description

[Beth Rennie [:beth] (she/her)]

Once we validate via telemetry that the shared sql database is operating as expected, we should migrate our reads over to that instead of the ExperimentDataStore. We will keep the ExperimentDataStore around until the end of bug 1956078 and continue to monitor telemetry, just in case.

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1956082 - Rename ExperimentStore._store to ._jsonFile r?#nimbus-reviewers

Comment 2

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1956082 - Read from NimbusEnrollments table at startup if enabled r?#nimbus-reviewers!,gijs!

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1956082 - Add the nimbusStore feature r?#nimbus-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/020194c9b64b
https://hg.mozilla.org/integration/autoland/rev/d8c33b1b2db6
Rename ExperimentStore._store to ._jsonFile r=nimbus-reviewers,relud
https://github.com/mozilla-firefox/firefox/commit/91e74363abfa
https://hg.mozilla.org/integration/autoland/rev/5d5af59cb4e3
Read from NimbusEnrollments table at startup if enabled r=Gijs,nimbus-reviewers,relud
https://github.com/mozilla-firefox/firefox/commit/9af5d282957e
https://hg.mozilla.org/integration/autoland/rev/a7504855037c
Add the nimbusStore feature r=nimbus-reviewers,relud

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2e9d7a13a8bd
https://hg.mozilla.org/integration/autoland/rev/0a0fdf753fd6
Revert "Bug 1956082 - Add the nimbusStore feature r=nimbus-reviewers,relud" for causing xpc failures @ test_Migrations.js

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_Migrations.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/0a0fdf753fd6369dbc7c72b7d34b2a94b5438acd

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/nimbus/test/unit/test_Migrations.js

Comment 7

[Beth Rennie [:beth] (she/her)]

I think I found another bug in preference handling :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b6db48dd4d01
https://hg.mozilla.org/integration/autoland/rev/3203903977fa
Rename ExperimentStore._store to ._jsonFile r=nimbus-reviewers,relud
https://github.com/mozilla-firefox/firefox/commit/c3471f37c09f
https://hg.mozilla.org/integration/autoland/rev/36e39d4c7be5
Read from NimbusEnrollments table at startup if enabled r=Gijs,nimbus-reviewers,relud
https://github.com/mozilla-firefox/firefox/commit/7ac09dd6a4bb
https://hg.mozilla.org/integration/autoland/rev/55ec1e67d9fd
Add the nimbusStore feature r=nimbus-reviewers,relud

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3203903977fa
https://hg.mozilla.org/mozilla-central/rev/36e39d4c7be5
https://hg.mozilla.org/mozilla-central/rev/55ec1e67d9fd