Closed Bug 1956229 Opened 1 month ago Closed 1 month ago

Perma devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js | The clipboard contains the environment variables suitable for startup profiling. - when Gecko 138 merges to beta on 2025-03-31

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

defect

Tracking

(firefox-esr115 unaffected, firefox-esr128 unaffected, firefox136 unaffected, firefox137 unaffected, firefox138+ verified)

VERIFIED FIXED
138 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox136 --- unaffected
firefox137 --- unaffected
firefox138 + verified

People

(Reporter: amarc, Assigned: julienw)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fxp])

Attachments

(1 file)

Central-as-beta-simulation

How to run these simulations

Failure log

  • Failure snippet:
[task 2025-03-25T12:35:41.457Z] 12:35:41     INFO - TEST-PASS | devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js | There is a button. - 
[task 2025-03-25T12:35:41.457Z] 12:35:41     INFO - TEST-PASS | devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js | The button contains a shadowDom. - 
[task 2025-03-25T12:35:41.458Z] 12:35:41     INFO - TEST-PASS | devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js | Test that the more actions button has a title - 
[task 2025-03-25T12:35:41.458Z] 12:35:41     INFO - Test that the button is clickable
[task 2025-03-25T12:35:41.461Z] 12:35:41     INFO - TEST-PASS | devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js | The item to restart with startup profiling has been displayed - 
[task 2025-03-25T12:35:41.461Z] 12:35:41     INFO - Will copy environment variables for startup profiling
[task 2025-03-25T12:35:41.462Z] 12:35:41     INFO - TEST-PASS | devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js | The item to copy environment variables for startup profiling is present in the menu - 
[task 2025-03-25T12:35:41.462Z] 12:35:41     INFO - Buffered messages finished
[task 2025-03-25T12:35:41.462Z] 12:35:41     INFO - TEST-UNEXPECTED-FAIL | devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js | The clipboard contains the environment variables suitable for startup profiling. - Got "MOZ_PROFILER_STARTUP='1' MOZ_PROFILER_STARTUP_INTERVAL='1' MOZ_PROFILER_STARTUP_ENTRIES='134217728' MOZ_PROFILER_STARTUP_FEATURES='screenshots,js,cpu,memory' MOZ_PROFILER_STARTUP_FILTERS='GeckoMain,Compositor,Renderer,DOM Worker'", expected "MOZ_PROFILER_STARTUP='1' MOZ_PROFILER_STARTUP_INTERVAL='1' MOZ_PROFILER_STARTUP_ENTRIES='134217728' MOZ_PROFILER_STARTUP_FEATURES='screenshots,js,stackwalk,cpu,processcpu,memory' MOZ_PROFILER_STARTUP_FILTERS='GeckoMain,Compositor,Renderer,SwComposite,DOM Worker'"
[task 2025-03-25T12:35:41.462Z] 12:35:41     INFO - Stack trace:
[task 2025-03-25T12:35:41.463Z] 12:35:41     INFO - chrome://mochikit/content/browser-test.js:test_is:1654
[task 2025-03-25T12:35:41.463Z] 12:35:41     INFO - chrome://mochitests/content/browser/devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js:test/<:85
[task 2025-03-25T12:35:41.463Z] 12:35:41     INFO - chrome://mochitests/content/browser/devtools/client/performance-new/test/browser/helpers.js:withAboutProfiling/<:446
[task 2025-03-25T12:35:41.463Z] 12:35:41     INFO - resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:121
[task 2025-03-25T12:35:41.464Z] 12:35:41     INFO - chrome://mochitests/content/browser/devtools/client/performance-new/test/browser/helpers.js:withAboutProfiling:436
[task 2025-03-25T12:35:41.464Z] 12:35:41     INFO - chrome://mochitests/content/browser/devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js:test:35
[task 2025-03-25T12:35:41.464Z] 12:35:41     INFO - chrome://mochikit/content/browser-test.js:handleTask:1170
[task 2025-03-25T12:35:41.465Z] 12:35:41     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1242
[task 2025-03-25T12:35:41.465Z] 12:35:41     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1383
[task 2025-03-25T12:35:41.465Z] 12:35:41     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1159
[task 2025-03-25T12:35:41.465Z] 12:35:41     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-03-25T12:35:41.466Z] 12:35:41     INFO - Will copy parameters for performance tests profiling
[task 2025-03-25T12:35:41.466Z] 12:35:41     INFO - TEST-PASS | devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js | The item to copy the parameters to performance tests is present in the menu - 
[task 2025-03-25T12:35:41.466Z] 12:35:41     INFO - GECKO(3408) | [Parent 3408, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/checkouts/gecko/dom/events/Clipboard.cpp:216
[task 2025-03-25T12:35:41.481Z] 12:35:41     INFO - GECKO(3408) | [Parent 3408: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 23 (7f6caf77fc00) [pid = 3408] [serial = 11] [outer = 0] [url = about:blank]
[task 2025-03-25T12:35:41.485Z] 12:35:41     INFO - GECKO(3408) | [Parent 3408: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 22 (7f6cbba28800) [pid = 3408] [serial = 14] [outer = 0] [url = about:blank]
[task 2025-03-25T12:35:41.486Z] 12:35:41     INFO - GECKO(3408) | [Parent 3408: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 21 (7f6cbfb5c400) [pid = 3408] [serial = 4] [outer = 0] [url = about:blank]
[task 2025-03-25T12:35:41.545Z] 12:35:41     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-03-25T12:35:41.546Z] 12:35:41     INFO - TEST-UNEXPECTED-FAIL | devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js | The clipboard contains the parameters suitable for performance tests. - Got "--gecko-profile --gecko-profile-interval 1 --gecko-profile-entries 134217728 --gecko-profile-features 'screenshots,js,cpu,memory' --gecko-profile-threads 'GeckoMain,Compositor,Renderer,DOM Worker'", expected "--gecko-profile --gecko-profile-interval 1 --gecko-profile-entries 134217728 --gecko-profile-features 'screenshots,js,stackwalk,cpu,processcpu,memory' --gecko-profile-threads 'GeckoMain,Compositor,Renderer,SwComposite,DOM Worker'"
[task 2025-03-25T12:35:41.546Z] 12:35:41     INFO - Stack trace:
[task 2025-03-25T12:35:41.547Z] 12:35:41     INFO - chrome://mochikit/content/browser-test.js:test_is:1654
[task 2025-03-25T12:35:41.547Z] 12:35:41     INFO - chrome://mochitests/content/browser/devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js:test/<:105
[task 2025-03-25T12:35:41.547Z] 12:35:41     INFO - chrome://mochitests/content/browser/devtools/client/performance-new/test/browser/helpers.js:withAboutProfiling/<:446
[task 2025-03-25T12:35:41.548Z] 12:35:41     INFO - resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:121
[task 2025-03-25T12:35:41.548Z] 12:35:41     INFO - chrome://mochitests/content/browser/devtools/client/performance-new/test/browser/helpers.js:withAboutProfiling:436
[task 2025-03-25T12:35:41.549Z] 12:35:41     INFO - chrome://mochitests/content/browser/devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js:test:35
[task 2025-03-25T12:35:41.549Z] 12:35:41     INFO - chrome://mochikit/content/browser-test.js:handleTask:1170
[task 2025-03-25T12:35:41.550Z] 12:35:41     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1242
[task 2025-03-25T12:35:41.550Z] 12:35:41     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1383
[task 2025-03-25T12:35:41.550Z] 12:35:41     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1159
[task 2025-03-25T12:35:41.550Z] 12:35:41     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-03-25T12:35:41.551Z] 12:35:41     INFO - Set the preference devtools.performance.aboutprofiling.has-developer-options to false
[task 2025-03-25T12:35:41.644Z] 12:35:41     INFO - GECKO(3408) | [Parent 3408: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f6c97179800 == 6 [pid = 3408] [id = 6] [url = about:profiling]
[task 2025-03-25T12:35:41.670Z] 12:35:41     INFO - Immediately trying to find the element with the text "Copy environment variables".
[task 2025-03-25T12:35:41.672Z] 12:35:41     INFO - TEST-PASS | devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js | The item to copy environment variables is not present. - 
[task 2025-03-25T12:35:41.672Z] 12:35:41     INFO - Immediately trying to find the element with the text "performance tests".
[task 2025-03-25T12:35:41.673Z] 12:35:41     INFO - TEST-PASS | devtools/client/performance-new/test/browser/browser_aboutprofiling-more-actions-menu.js | the item to copy the parameters for performance tests is not present. - 
Flags: needinfo?(felash)
Regressed by: 1908308
No longer regressed by: 1955997

I'm looking at it, thanks for the notice.

Severity: -- → S4
Flags: needinfo?(felash)
Priority: -- → P1
Whiteboard: [fxp]

I'm confused, I don't reproduce at the moment, after doing the central-as-beta simulation locally :/

We were already trying to do it before that, but this wasn't working
properly. Now we simulate a real mouse click to click the preset.
This also adds a sanity check in the test.

Assignee: nobody → felash
Status: NEW → ASSIGNED

I didn't reproduce locally, but I still found what the problem was. I fixed it a little bit blindly, but I'm confident.

Pushed by jwajsberg@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5654cdb1f3c3 Make sure the Firefox/Nightly preset is really selected when testing r=canaltinova,profiler-reviewers
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
Regressions: 1956393

I believe the fix landed here isn't correct.
Hopefully the fix for bug 1956393 should work now.

Even though I didn't manage to reproduce the problem with a local central-to-beta simulation.

Status: RESOLVED → REOPENED
Flags: needinfo?(felash)
Resolution: FIXED → ---
Target Milestone: 138 Branch → ---

see comment 7, should be fixed in bug 1956393.
I'm closing this bug again for clarity.

Flags: needinfo?(felash)
Status: REOPENED → RESOLVED
Closed: 1 month ago1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch

bug 1956393 landed some hours ago. I hope this won't come back, but if you still see a problem, can you please file a new bug for an easier tracking? Thanks :-)

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: