1957042 - Upgrade to UniFFI 0.29.1

Status: RESOLVED FIXED

(Toolkit :: UniFFI Bindings, task)

Description

[Jan-Erik Rediger [:janerik]]

In bug 1950665 we did try to upgrade to 0.29.1 straight away.
However that brought in #[unsafe()] annotations and those require Rust 1.82.0 and while we build Firefox on 1.82.0 the TSAN/ASAN tasks use a dev build of rust, to apply additional patches, that is kinda-but-not-really 1.82.0, just before #[unsafe()] got stable.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1945020#c8

We need that resolved before we can bring in uniffi 0.29.1 (and later). And probably other crates as they migrate to MSRV 1.82.0

try run where we hit that: https://treeherder.mozilla.org/jobs?repo=try&revision=ec5542a75471592a52811fa343f77ac97d2ed330
logs:

• asan
• tsan

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

We might be able to unblock this by cherry picking patches for unsafe attributes against the nightly Rust toolchain versionwe use . I'm not sure if that would result in a correct toolchain, but we can at least try it; the patch for stabilizing applies cleanly, at any rate.

NI'ing :glandium for thoughts.

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

It looks like rust#128771 stabilized unsafe attributes, and was only 3ish days after the commit that we're using for sanitizer builds. I strongly suspect this will work, if unsafe attributes are all that is necessary. I'll file a patch.

Comment 3

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1957042 - build(rust): patch stabilization of `unsafe` attributes in Rust for sanitizer builds r=glandium

Comment 4

[Erich Gubler [:ErichDonGubler] (he/him)]

Aha, here's the Try push I just did with the patch I attached in comment 3: try:9bb5838dfd75

Looking good! I'll just punt the NI to a review from :glandium now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/839829bda350
build(rust): patch stabilization of `unsafe` attributes in Rust for sanitizer builds r=glandium

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/839829bda350

Comment 7

[Jan-Erik Rediger [:janerik]]

I put a try run on today with the uniffi 0.29.1 update applied (among the other glean & a-s update): https://treeherder.mozilla.org/jobs?repo=try&revision=5c97b03666dfa646f9c111dec6c15cada3feb4a6

Both asan and tsan seems to be passing now. We can probably pull in 0.29.1 along with the Glean update. So I'll probably do that as part of re-landing bug 1953191

Comment 8

[Erich Gubler [:ErichDonGubler] (he/him)]

That sounds encouraging! I'm glad I could help. 🙂

Comment 9

[Jan-Erik Rediger [:janerik]]

Happened in bug 1950665