Closed Bug 1957508 Opened 8 months ago Closed 8 months ago

The hyperlink color became unreadable on dark mode

Categories

(Thunderbird :: Mail Window Front End, defect, P1)

Product:
Thunderbird
Component:
Mail Window Front End
Version:
Thunderbird 138
Type:
defect

Tracking

(thunderbird_esr128 unaffected, thunderbird137 unaffected, thunderbird138 fixed)

Status:
RESOLVED FIXED
Milestone:
139 Branch
Tracking Flags:
Tracking Status
thunderbird_esr128 --- unaffected
thunderbird137 --- unaffected
thunderbird138 --- fixed

People

(Reporter: saschanaz, Assigned: Paenglab)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

2025-03-12-bad.png
312.40 KB, image/png
Details
2025-03-11-good.png
309.97 KB, image/png
Details
Bug 1957508 - Set color-scheme: light dark; in messages to get the correct colors. r=#thunderbird-front-end-reviewers
48 bytes, text/x-phabricator-request
corey
: approval-comm-beta+
Details | Review
Attached image 2025-03-12-bad.png —

I'm not sure how the bug 1920130 is related here, but mozregression still points to that one.

Here's the source of the email:

--===============2917853430489401360==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<!doctype html>
<html lang=3D"en">
<head>
<meta charset=3D"utf-8">
<title>Weekly github digest (WebApps WG specs)</title>
<style>
body { font-family: Gotham, "Helvetica Neue", Helvetica, Arial, sans-serif;=
 font-size: 14px; }
h2 { margin-top: 3em; color: #A52A2A; font-style: italic; font-weight: norm=
al; }
h3 { margin-bottom:0; margin-top: 2em; font-size: 1.2em; }
h1+h2 { margin-top: 1em; }
a { color: #bb6219; text-decoration: none; }
li { margin-bottom: .35em; }
.repos { margin-bottom: 0; margin-top:0; line-height: 1.2; }
.new { color: red; }
.label { display: inline;
	padding: .2em .6em .3em;
	font-size: 75%;
	font-weight: 700;
	line-height: 1;
	color: #fff;
	text-align: center;
	white-space: nowrap;
	vertical-align: baseline;
	border-radius: .25em;
}
details {
	margin-top: 8em;
	}
summary {
	margin-bottom: 1em;
	cursor: pointer;
}
</style>
</head>

<body>
<h1>Monday March 31, 2025</h1>


<h2>Issues</h2>

<h3>w3c/image-resource (+0/-1/=F0=9F=92=AC0)</h3>


  <p>1 issues closed:</p>
  <ul>
  <li>#44 <a href=3D"https://github.com/w3c/image-resource/issues/44">TPAC =
2022 status report</a> </li>
  </ul>

<h3>w3c/IndexedDB (+0/-1/=F0=9F=92=AC1)</h3>

  <p>1 issues received 1 new comments:</p>
  <ul>
  <li>#69 <a href=3D"https://github.com/w3c/IndexedDB/issues/69">Feature Re=
quest: Allow batch adding records (from an Array)</a> (1 by shadow-identity=
) <span class=3D"label" style=3D"background-color: #84b6eb; color: #000000"=
>feature request</span> <span class=3D"label" style=3D"background-color: #b=
60205; color: #ffffff">needs-pr</span> <span class=3D"label" style=3D"backg=
round-color: #fbca04; color: #000000">performance</span> <span class=3D"lab=
el" style=3D"background-color: #31eab2; color: #000000">TPAC 2019</span> <s=
pan class=3D"label" style=3D"background-color: #ED400D; color: #ffffff">TPA=
C2024</span> </li>
  </ul>

  <p>1 issues closed:</p>
  <ul>
  <li>#443 <a href=3D"https://github.com/w3c/IndexedDB/issues/443">error in=
 an example of the behavior of in-line keys and key generators</a> <span cl=
ass=3D"label" style=3D"background-color: #b60205; color: #ffffff">needs-pr<=
/span> </li>
  </ul>

<h3>w3c/manifest (+0/-0/=F0=9F=92=AC1)</h3>

  <p>1 issues received 1 new comments:</p>
  <ul>
  <li>#1148 <a href=3D"https://github.com/w3c/manifest/issues/1148">Unbind =
computed id from start_url</a> (1 by dmurph) </li>
  </ul>


<h3>w3c/push-api (+1/-0/=F0=9F=92=AC3)</h3>
  <p class=3D"new">1 issues created:</p>
  <ul>
  <li>#399 <a href=3D"https://github.com/w3c/push-api/issues/399">Add a way=
 to cancel previous push notification</a> (by saschanaz) </li>
  </ul>

  <p>2 issues received 3 new comments:</p>
  <ul>
  <li>#399 <a href=3D"https://github.com/w3c/push-api/issues/399">Add a way=
 to cancel previous push notification</a> (2 by martinthomson, saschanaz) <=
/li>
 =20
  <li>#360 <a href=3D"https://github.com/w3c/push-api/issues/360">Declarati=
ve Web Push</a> (1 by Turbocat6413) </li>
  </ul>


<h3>whatwg/dom (+0/-0/=F0=9F=92=AC41)</h3>

  <p>2 issues received 41 new comments:</p>
  <ul>
  <li>#1363 <a href=3D"https://github.com/whatwg/dom/issues/1363">Naming of=
 Composed Range</a> (1 by dizhang168) <span class=3D"label" style=3D"backgr=
ound-color: #009800; color: #ffffff">topic: shadow</span> <span class=3D"la=
bel" style=3D"background-color: #009800; color: #ffffff">topic: ranges</spa=
n> </li>
 =20
  <li>#736 <a href=3D"https://github.com/whatwg/dom/issues/736">Proposal: a=
 DocumentFragment whose nodes do not get removed once inserted</a> (40 by D=
eepDoge, FrameMuse, WebReflection, rniwa, robbiespeed) <span class=3D"label=
" style=3D"background-color: #5319e7; color: #ffffff">needs implementer int=
erest</span> <span class=3D"label" style=3D"background-color: #006b75; colo=
r: #ffffff">addition/proposal</span> </li>
  </ul>




<h2>Pull requests</h2>
<h3>w3c/geolocation-api (+0/-0/=F0=9F=92=AC1)</h3>

  <p>1 pull requests received 1 new comments:</p>
  <ul>
  <li>#183 <a href=3D"https://github.com/w3c/geolocation/pull/183">Addition=
: support geolocation emulation</a> (1 by reillyeon) </li>
  </ul>


<h3>w3c/IndexedDB (+1/-1/=F0=9F=92=AC3)</h3>
  <p class=3D"new">1 pull requests submitted:</p>
  <ul>
  <li>#444 <a href=3D"https://github.com/w3c/IndexedDB/pull/444">erratum in=
 Example 6 regarding behavior of key generator with in-line key</a> (by cha=
irmank) </li>
  </ul>

  <p>1 pull requests received 3 new comments:</p>
  <ul>
  <li>#444 <a href=3D"https://github.com/w3c/IndexedDB/pull/444">erratum in=
 Example 6 regarding behavior of key generator with in-line key</a> (3 by c=
hairmank, inexorabletash, w3cbot) </li>
  </ul>

  <p>1 pull requests merged:</p>
  <ul>
  <li>#444 <a href=3D"https://github.com/w3c/IndexedDB/pull/444">erratum in=
 Example 6 regarding behavior of key generator with in-line key</a> </li>
  </ul>

<h3>whatwg/dom (+0/-0/=F0=9F=92=AC2)</h3>

  <p>1 pull requests received 2 new comments:</p>
  <ul>
  <li>#1342 <a href=3D"https://github.com/whatwg/dom/pull/1342">Add definit=
ion for composed selection range</a> (2 by dizhang168, sefeng211) </li>
  </ul>



  <details>
    <summary>Repositories tracked by this digest:</summary>
<ul class=3D"repos">
  <li><a href=3D"https://github.com/w3c/badging">https://github.com/w3c/bad=
ging</a></li>
  <li><a href=3D"https://github.com/w3c/contact-picker">https://github.com/=
w3c/contact-picker</a></li>
  <li><a href=3D"https://github.com/w3c/deviceorientation">https://github.c=
om/w3c/deviceorientation</a></li>
  <li><a href=3D"https://github.com/w3c/FileAPI">https://github.com/w3c/Fil=
eAPI</a></li>
  <li><a href=3D"https://github.com/w3c/gamepad">https://github.com/w3c/gam=
epad</a></li>
  <li><a href=3D"https://github.com/w3c/geolocation-api">https://github.com=
/w3c/geolocation-api</a></li>
  <li><a href=3D"https://github.com/w3c/image-resource">https://github.com/=
w3c/image-resource</a></li>
  <li><a href=3D"https://github.com/w3c/IndexedDB">https://github.com/w3c/I=
ndexedDB</a></li>
  <li><a href=3D"https://github.com/w3c/IntersectionObserver">https://githu=
b.com/w3c/IntersectionObserver</a></li>
  <li><a href=3D"https://github.com/w3c/manifest">https://github.com/w3c/ma=
nifest</a></li>
  <li><a href=3D"https://github.com/w3c/pointerlock">https://github.com/w3c=
/pointerlock</a></li>
  <li><a href=3D"https://github.com/w3c/push-api">https://github.com/w3c/pu=
sh-api</a></li>
  <li><a href=3D"https://github.com/w3c/screen-orientation">https://github.=
com/w3c/screen-orientation</a></li>
  <li><a href=3D"https://github.com/w3c/screen-wake-lock">https://github.co=
m/w3c/screen-wake-lock</a></li>
  <li><a href=3D"https://github.com/w3c/uievents">https://github.com/w3c/ui=
events</a></li>
  <li><a href=3D"https://github.com/w3c/web-locks">https://github.com/w3c/w=
eb-locks</a></li>
  <li><a href=3D"https://github.com/w3c/web-share">https://github.com/w3c/w=
eb-share</a></li>
  <li><a href=3D"https://github.com/whatwg/dom">https://github.com/whatwg/d=
om</a></li>
  <li><a href=3D"https://github.com/whatwg/infra">https://github.com/whatwg=
/infra</a></li>
  <li><a href=3D"https://github.com/whatwg/webidl">https://github.com/whatw=
g/webidl</a></li>
</ul>
</details>
<address>Sent via github-notify-ml as configured in https://github.com/w3c/=
github-notify-ml-config</address>
</body>
</html>

--===============2917853430489401360==--
status-thunderbird137: --- → unaffected
status-thunderbird138: --- → affected
status-thunderbird_esr128: --- → unaffected
Priority: -- → P1
Version: unspecified → Thunderbird 138

(In reply to Kagami Rosylight [:saschanaz] (they/them) from comment #0)

I'm not sure how the bug 1920130 is related here, but mozregression still points to that one.

IME, if mozregression shows a comm-central commit that seems entirely unrelated, it's likely (though not always the case) the issue started happening as a side-effect of a change in something we reuse from mozilla-central.

The mozilla-central push matching the comm-central push for bug 1920130 is: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=97fe6a90f114eebeaec0e1c466dcdcc554eb1d3b&tochange=cf57ffa15763ffb875b6b468825a67b537c264f8

In there, bug 1952693 seems like a likely culprit. The change shown in the screenshots you shared look consistent with a colour change from #0066cc to #0000ee.

Component: Account Manager → Mail Window Front End
Regressed by: 1952693
No longer regressed by: 1920130

The right thing to do is using color-scheme: dark on those messages.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Keywords: checkin-needed-tb
Target Milestone: --- → 139 Branch

Pushed by brendan@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/ef29a9235653
Set color-scheme: light dark; in messages to get the correct colors. r=freaktechnik

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Comment on attachment 9477148 [details]
Bug 1957508 - Set color-scheme: light dark; in messages to get the correct colors. r=#thunderbird-front-end-reviewers

Uplift Approval Request

  • Please state case for uplift consideration and ensure bug severity is set: In messages links and other colours aren't correctly set with dark reader.
  • User impact if declined: Too low contrast for links and other things.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Daily?: Yes
  • Has the fix been verified in Beta?: N/A
  • Needs manual test from QA?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small CSS change.
  • String changes made/needed: no
Attachment #9477148 - Flags: approval-comm-beta?
Regressions: 1958728

Comment on attachment 9477148 [details]
Bug 1957508 - Set color-scheme: light dark; in messages to get the correct colors. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Attachment #9477148 - Flags: approval-comm-beta? → approval-comm-beta+
See Also: → 1963293
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: