Closed Bug 1957542 Opened 26 days ago Closed 26 days ago

[NativeLayerWayland::UpdateLayer] Crash in [@ mozilla::widget::WaylandBuffer::BorrowBuffer] after update to 137 from 136

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Version:
Firefox 137
Platform:
Unspecified
Linux
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: stalkerg, Unassigned)

References

Details

On GitLab or GitHub websites, parts of the screen start flickering, especially when scrolling. On GitLab, it even crashes.
Version 136 is working fine.

Crash report: https://crash-stats.mozilla.org/report/index/a9a40187-9e58-42df-985c-222990250401

MOZ_CRASH Reason:

MOZ_RELEASE_ASSERT(!mAttachedToSurface && !mIsAttachedToCompositor) (We're already attached!)

Top 10 frames:

0  libxul.so  MOZ_CrashSequence(void*, long)  mfbt/Assertions.h:267
0  libxul.so  mozilla::widget::WaylandBuffer::BorrowBuffer(mozilla::widget::WaylandSurfaceL...  widget/gtk/WaylandBuffer.cpp:103
1  libxul.so  mozilla::widget::WaylandSurface::AttachLocked(mozilla::widget::WaylandSurface...  widget/gtk/WaylandSurface.cpp:1213
2  libxul.so  mozilla::layers::NativeLayerWaylandRender::CommitSurfaceToScreenLocked(mozill...  gfx/layers/NativeLayerWayland.cpp:925
3  libxul.so  mozilla::layers::NativeLayerWayland::UpdateLayer(double)  gfx/layers/NativeLayerWayland.cpp:658
4  libxul.so  mozilla::layers::NativeLayerRootWayland::UpdateLayersLocked(mozilla::detail::...  gfx/layers/NativeLayerWayland.cpp:375
5  libxul.so  mozilla::layers::NativeLayerRootWayland::CommitToScreenLocked(mozilla::detail...  gfx/layers/NativeLayerWayland.cpp:464
6  libxul.so  mozilla::layers::NativeLayerRootWayland::CommitToScreen()  gfx/layers/NativeLayerWayland.cpp:421
7  libxul.so  mozilla::wr::RenderCompositorNative::CompositorEndFrame()  gfx/webrender_bindings/RenderCompositorNative.cpp:270
8  libxul.so  webrender::renderer::Renderer::render_impl  gfx/wr/webrender/src/renderer/mod.rs:1769

It's also a case for other websites; I saw it even on bugzilla.

The assert seemed to be added by Bug 1942232.

:stransky, can you comment to this bug?

Flags: needinfo?(stransky)
See Also: → 1942232

Please test latest nightly with HDR mode enabled. 137 is not supposed to work.

Status: UNCONFIRMED → RESOLVED
Closed: 26 days ago
Flags: needinfo?(stransky)
Resolution: --- → WONTFIX
Summary: Crash in [@ mozilla::widget::WaylandBuffer::BorrowBuffer] after update to 137 from 136 → [NativeLayerWayland::UpdateLayer] Crash in [@ mozilla::widget::WaylandBuffer::BorrowBuffer] after update to 137 from 136

For explanation - NativeLayerWaylandRender is used to render HDR content and it's still WIP (Bug 1642854). Report bugs from latest nightly only please.

I am not using HDR; KWin is also not currently in HDR mode.

Basically, I have only one change for wayland in Firefox - widget.wayland.vsync.enabled is False.

You have set gfx.webrender.compositor or gfx.webrender.compositor.force-enabled or gfx.wayland.hdr pref.

Look on about:support page at WEBRENDER_COMPOSITOR field, it needs to be disabled.

gfx.webrender.compositor

Yes, I only have this one; before, it needed to work correctly inside Wayland. Why is it connected with HDR now, even if I have no HDR?
I will test it now. Thanks.

Yep, it seems to work correctly after that change. Thank you again.
Hm, but it was a little bit unexpected.

See Bug 1957568 for reference. Composited rendering was disabled before, we enabled it for HDR rendering which is not finished yet.

You need to log in before you can comment on or make changes to this bug.