1957643 - The menu items for the folders inside the bookmark toolbar is quite narrow in the Compact Mode

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Tooru Fujisawa [:arai]]

Attachment: menu size

(although it's marked "not supported", filing this just in case)

Steps to Reproduce:

1. Run Nightly 139.0a1 (2025-04-01) (aarch64) with clean profile on macOS
2. Secondary-click on the toolbar and select "Bookmarks Toolbar" - "Always Show"
3. Open "about:config"
4. Set browser.compactmode.show to true
5. Secondary-click on the toolbar and select "Customize Toolbar"
6. Select "Density" - "Compact (not supported)"
7. Secondary-click on the Bookmarks Toolbar and "Add Folder..."
8. Click "Save"
9. Open "https://bugzilla.mozilla.org/"
10. Drag-and-drop the tab ("Bugzilla Main Page") into the "New Folder" inside the Bookmarks Toolbar, 3 times
11. Click the "New Folder" folder inside the Bookmarks Toolbar

Expected result:
The attached screenshot, "Before" section.

Actual result:
The attached screenshot, "After" section.
The menu item's height becomes narrower

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1957643 - Choose a more reasonable padding block in compact mode. r=#theme

This used to look reasonable because of this min-height:

https://searchfox.org/mozilla-central/rev/60acd1356b659b858e5f712cc217768aae17fde1/browser/themes/shared/customizableui/panelUI-shared.css#1193

But this gives better results in the general case, and gets you roughly
the same rendering.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1954977

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c99930fecfb8
Choose a more reasonable padding block in compact mode. r=desktop-theme-reviewers,Itiel

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c99930fecfb8

Comment 5

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly from 2025-04-01 on macOS 13.7. Verified that using latest Nightly 140.0a1 and Firefox 139.0b4 the behavior matches the behavior from the Expected result from comment 0.