1957923 - Fix falling back to built in notifications on first run

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Martin Giger [:freaktechnik]]

When we open a profile for the first time, we always fall back to the built in notifications. This is because we think we can't update and have an empty cache, so we use the built in notifications immediately.

Instead, we should be waiting until the user has at least interacted with the privacy policy, reducing the pressure of new things a bit.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1957923 - Wait to use built in notifications until after first run. r=tobyp,arschmitz

This makes it so we will effectively never use built in notifications in the first run of a profile. I think that's generally fine. If we for some reason can't update from the network on the first run, we probably want to wait to the second run with built in notifications anyway.

Comment 2

[Martin Giger [:freaktechnik]]

This will uplift fine on top of bug 1957538.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d0bfaba59a26
Wait to use built in notifications until after first run. r=arschmitz

Comment 4

[Martin Giger [:freaktechnik]]

Comment on attachment 9476605 [details]
Bug 1957923 - Wait to use built in notifications until after first run. r=tobyp,arschmitz

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: For the best experience for our users we shouldn't be prompting them for multiple appeals at the same time. Without this fix, we greet all new users with two different appeals, one of them piling in during first run.
• User impact if declined: Getting the built in fallback in-app notification on new profiles at first run (and then the normal appeal and in-app notifications the next restart)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: No
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce: - Open the application with a new profile
• List of other uplifts needed: bug 1957538
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Changes startup logic for in-app notifications and depends on another patch adjusting that logic. However, the patch is fully covered by automated tests.
• String changes made/needed: none

Comment 5

[Martin Giger [:freaktechnik]]

Comment on attachment 9476605 [details]
Bug 1957923 - Wait to use built in notifications until after first run. r=tobyp,arschmitz

Same answers as in the beta uplift request above. I've tried applying it to esr with the patch from bug 1957538. I haven't yet checked release, it's possible we'll hit some merge conflicts there. I'll try to check that asap.

Comment 6

[Martin Giger [:freaktechnik]]

Comment on attachment 9476605 [details]
Bug 1957923 - Wait to use built in notifications until after first run. r=tobyp,arschmitz

got the wrong flag, sorry.

Comment 7

[Martin Giger [:freaktechnik]]

Okay, seems to apply fine to comm-release with the patch from bug 1957538 as well.

Comment 8

[Daniel Darnell [:dandarnell]]

Comment on attachment 9476605 [details]
Bug 1957923 - Wait to use built in notifications until after first run. r=tobyp,arschmitz

[Triage Comment]
Approved for beta, per discussion w/ Wayne and Toby on Zoom/Matrix

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9476605 [details]
Bug 1957923 - Wait to use built in notifications until after first run. r=tobyp,arschmitz

[Triage Comment]
Approved for esr128
Approved for release

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 137.0.1:
https://hg.mozilla.org/releases/comm-release/rev/016ee19491a3

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 128.9.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/dabe66f58c27

Comment 12

[Daniel Darnell [:dandarnell]]

Thunderbird 138.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/85d2bde50441