1957949 - Remove old appeal in favor of in-app notifications

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Martin Giger [:freaktechnik]]

With the in-app notification system we are replacing the old appeal system, so the old appeal should be removed as we're starting to use the new system.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1957949 - Remove EOY appeal in favor of in-app notifications. r=tobyp

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: bug1957949beta.diff

[User impact if declined]
New users will still see the old appeal, even though we're starting a new appeal through a new system. If we were still using this appeal system this would be a patch to update the values in the prefs instead.

[Is this code covered by automated tests?]

• Options: No

[Has the fix been verified in Daily? (or Beta for an ESR uplift?)]
I know Toby has done some testing, I've obviously applied it to the beta tree but haven't built it on beta. I've built it for comm-central, where it behaved as I'd expect (no more classic appeal)

[Needs manual test from QA?]

• Options: Yes
• To test, make sure that no tab with the URL https://updates.thunderbird.net/thunderbird/128.0/dec24/ opens on first or second run of a profile. Or in an existing profile after resetting the app.donation.eoy.version.viewed pref.

[List of other uplifts needed]
none

[Risk to taking this patch]

• Options: Low
  Purely code removal of a fairly self-contained system (that was designed to be modified through uplifts)

[Why is the change risky/not risky? (and alternatives if risky)]
The biggest risk I can think of is that this somehow affects startup of the application, however I think that is very unlikely, as justified above.

[String changes made/needed]
none

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9476751 [details] [diff] [review]
bug1957949beta.diff

Same request form as above. Checked that this applies.

Comment 4

[Martin Giger [:freaktechnik]]

Attachment: bug1957949esr128.diff

[User impact if declined]
New users will still see the old appeal, even though we're starting a new appeal through a new system. If we were still using this appeal system this would be a patch to update the values in the prefs instead.

[Is this code covered by automated tests?]

• Options: No

[Has the fix been verified in Daily? (or Beta for an ESR uplift?)]
There has been manual testing on Daily. This patch is made to apply to ESR, however I have not built ESR with it.

[Needs manual test from QA?]

• Options: Yes
• To test, make sure that no tab with the URL https://updates.thunderbird.net/thunderbird/128.0/dec24/ opens on first or second run of a profile. Or in an existing profile when restarting after resetting the app.donation.eoy.version.viewed pref.

[List of other uplifts needed]
none

[Risk to taking this patch]

• Options: Low
• Purely code removal of a fairly self-contained system (that was designed to be modified through uplifts)

[Why is the change risky/not risky? (and alternatives if risky)]
The biggest risk I can think of is that this somehow affects startup of the application, however I think that is very unlikely, as justified above.

[String changes made/needed]
none

Comment 5

[Daniel Darnell [:dandarnell]]

Comment on attachment 9476751 [details] [diff] [review]
bug1957949beta.diff

[Triage Comment]
Approved for beta, per discussion w/ Wayne and Toby on Zoom/Matrix

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/629eec284a79
Remove EOY appeal in favor of in-app notifications. r=tobyp

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9476751 [details] [diff] [review]
bug1957949beta.diff

[Triage Comment]
Approved for release

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9476753 [details] [diff] [review]
bug1957949esr128.diff

[Triage Comment]
Approved for esr128

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 137.0.1:
https://hg.mozilla.org/releases/comm-release/rev/1a8ef83731f2

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 128.9.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/6bb79fbc9087

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 138.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/90350ca24733