1958028 - Wallpapers do not override theme text color when personalization menu is closed

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Amy Churchwell [:amy]]

Attachment: screen-recording.mov

When selecting a light colored solid color wallpaper, initially the text is black but once the personalization menu is closed it becomes white. (See attached screen recording)

Comment 1

[Amy Churchwell [:amy]]

updateWallpaper() was recently moved out of render() in bug 1954759, which includes some code relating to text color contrast. I think this logic needs to be updated.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: New_Tab_screenshot.png

I can reproduce this bug when closing the New Tab personalization menu, but also intermittently (maybe 10% of the time?) when just opening a New Tab with Ctrl+T. The New Tab text like the weather widget and "Thought-provoking stories" section title are dark text on my dark New Tab background color. Seems like a race condition between checking the New Tab's background color and deciding the text color.

Comment 3

[npypchenko]

Cannot attach a video as it's too large, but this also affects dark image wallpapers, e.g. the very first option in the "Abstract" selection.

Comment 4

[Scott [:thecount] Downe]

Attachment: Bug 1958028 - Newtab fixing wallpapers do not override theme text color when personalization menu is closed

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf7b66226af1
Newtab fixing wallpapers do not override theme text color when personalization menu is closed r=home-newtab-reviewers,amy

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cf7b66226af1