1958067 - Decide what to do with AutofillTelemetry code calling .clear on legacy telemetry histograms

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect)

Description

[Florian Quèze [:florian]]

There are two calls to histogram.clear() in AutofillTelemetry.sys.mjs: https://searchfox.org/mozilla-central/rev/e339b9d6175e30310f6891a5e85d27ce43ad94f1/toolkit/components/formautofill/shared/AutofillTelemetry.sys.mjs#190,382

The related histograms are AUTOFILL_PROFILE_NUM_USES and CREDITCARD_NUM_USES.

Is the data generated by this instrumentation in use? If not I'm happy to provide a removal patch. If it is used, then I would need help to figure out a migration strategy.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1958067 - Remove AUTOFILL_PROFILE_NUM_USES and CREDITCARD_NUM_USES telemetry r=NeilDeakin

Comment 2

[Dimi Lee [:dimi]]

(In reply to Florian Quèze [:florian] from comment #0)

Is the data generated by this instrumentation in use? If not I'm happy to provide a removal patch. If it is used, then I would need help to figure out a migration strategy.

We are not using the telemetry now, I'll remove those telemetry :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e702e7f58dd0
Remove AUTOFILL_PROFILE_NUM_USES and CREDITCARD_NUM_USES telemetry r=NeilDeakin,credential-management-reviewers

Comment 4

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures at browser_creditCard_telemetry_autofill.js

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b41d1843040e
Remove AUTOFILL_PROFILE_NUM_USES and CREDITCARD_NUM_USES telemetry r=NeilDeakin,credential-management-reviewers

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b41d1843040e