1956726 - Migrate histograms to Glean - part 4 landing in Firefox 139

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task)

Description

[Florian Quèze [:florian]]

Continuation of bug 1935420, bug 1944631 and bug 1950710.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in gfx/, r=chutten.

Comment 2

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - remove the CONTENT_FRAME_TIME_REASON histogram that has already been migrated to Glean, r=chutten.

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs for WEBFONT_*, r=chutten.

Comment 4

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in toolkit/components/crashes/CrashManager.in.sys.mjs, r=chutten.

Comment 5

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs for ipc related histograms, r=chutten.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cee4b41c859b
Migrate histograms to use Glean APIs in toolkit/components/crashes/CrashManager.in.sys.mjs, r=chutten,gsvelto.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3f49f5c868a
Migrate histograms to use Glean APIs for ipc related histograms, r=chutten,media-playback-reviewers,padenot.

Comment 8

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in browser/, r=chutten.

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cee4b41c859b
https://hg.mozilla.org/mozilla-central/rev/f3f49f5c868a

Comment 10

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs for WEAVE_*, r=chutten.

Comment 11

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs for STARTUP_CACHE_REQUESTS, r=chutten.

Comment 12

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in extensions/permissions/, r=chutten.

Comment 13

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in dom/security/, r=chutten.

Comment 14

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in security/manager/ssl/, r=chutten.

Comment 15

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs for SANDBOX_*, r=chutten.

Comment 16

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in netwerk/protocol/http/, r=chutten.

Comment 17

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in netwerk/protocol/websocket/, r=chutten.

Comment 18

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs for NETWORK_ID* histograms, r=chutten.

Comment 19

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in netwerk/, r=chutten.

Comment 20

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in dom/, r=chutten.

Comment 21

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in layout/, r=chutten.

Comment 22

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in js/xpconnect/, r=chutten.

Comment 23

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs for SECURITY_UI, r=chutten.

Comment 24

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs for TOUCH_ENABLED_DEVICE, r=chutten.

Comment 25

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs in xpcom/, r=chutten.

Comment 26

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - remove leftover histogram SYSTEM_FONT_FALLBACK_SCRIPT from Histograms.json, r=chutten.

Comment 27

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs for SAFE_MODE_USAGE, r=chutten.

Comment 28

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - remove the unused PAGE_METADATA_SIZE histogram, r=mconley.

Comment 29

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - Migrate histograms to use Glean APIs for REL_PRELOAD_MISS_RATIO, r=chutten.

Comment 30

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - remove the now unused Telemetry::AccumulateCategorical API, r=chutten.

Comment 31

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - remove the now unused Telemetry::AccumulateTimeDelta APIs, r=chutten.

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e76e0cd9ecda
Migrate histograms to use Glean APIs in gfx/, r=chutten,jgilbert,firefox-desktop-core-reviewers ,mconley.
https://hg.mozilla.org/integration/autoland/rev/dc72f2ab80cc
remove the CONTENT_FRAME_TIME_REASON histogram that has already been migrated to Glean, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/f15032198899
Migrate histograms to use Glean APIs for WEBFONT_*, r=chutten.

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc75b87d1275
remove the unused PAGE_METADATA_SIZE histogram, r=mconley.

Comment 34

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - remove leftover Telemetry.h includes in header files, r=chutten.

Comment 35

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - remove leftover Telemetry.h includes in .cpp files, r=chutten.

Comment 36

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - remove the now unused variants of the Telemetry::Accumulate API, r=chutten.

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73bbcaf2d1ab
Migrate histograms to use Glean APIs in browser/, r=chutten,sessionstore-reviewers,tabbrowser-reviewers,mconley,nsharpley.

Comment 38

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cab8e793498
Migrate histograms to use Glean APIs for STARTUP_CACHE_REQUESTS, r=chutten.

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d86f4e4be856
Migrate histograms to use Glean APIs in extensions/permissions/, r=chutten,permissions-reviewers,emz.
https://hg.mozilla.org/integration/autoland/rev/b105388864df
Migrate histograms to use Glean APIs in dom/security/, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/11a70efd2f8d
Migrate histograms to use Glean APIs in security/manager/ssl/, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/20f19536943b
Migrate histograms to use Glean APIs for SANDBOX_*, r=chutten.

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62c75aece981
Migrate histograms to use Glean APIs in dom/, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/9132daa36be4
Migrate histograms to use Glean APIs in layout/, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/73f77fc149b9
Migrate histograms to use Glean APIs in js/xpconnect/, r=chutten.

Comment 41

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38a41abea60d
Migrate histograms to use Glean APIs for SECURITY_UI, r=chutten.

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cebcc581e0e
Migrate histograms to use Glean APIs for TOUCH_ENABLED_DEVICE, r=chutten,win-reviewers,gstoll.
https://hg.mozilla.org/integration/autoland/rev/8252dab03823
Migrate histograms to use Glean APIs in xpcom/, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/1caca0678caf
remove leftover histogram SYSTEM_FONT_FALLBACK_SCRIPT from Histograms.json, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/22ed2a87b327
Migrate histograms to use Glean APIs for SAFE_MODE_USAGE, r=chutten.

Comment 43

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c17dd8efbeb5
Migrate histograms to use Glean APIs for WEAVE_*, r=chutten,sync-reviewers,markh.

Comment 44

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e76e0cd9ecda
https://hg.mozilla.org/mozilla-central/rev/dc72f2ab80cc
https://hg.mozilla.org/mozilla-central/rev/f15032198899
https://hg.mozilla.org/mozilla-central/rev/bc75b87d1275
https://hg.mozilla.org/mozilla-central/rev/73bbcaf2d1ab
https://hg.mozilla.org/mozilla-central/rev/4cab8e793498
https://hg.mozilla.org/mozilla-central/rev/d86f4e4be856
https://hg.mozilla.org/mozilla-central/rev/b105388864df
https://hg.mozilla.org/mozilla-central/rev/11a70efd2f8d
https://hg.mozilla.org/mozilla-central/rev/20f19536943b

Comment 45

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/62c75aece981
https://hg.mozilla.org/mozilla-central/rev/9132daa36be4
https://hg.mozilla.org/mozilla-central/rev/73f77fc149b9
https://hg.mozilla.org/mozilla-central/rev/38a41abea60d
https://hg.mozilla.org/mozilla-central/rev/4cebcc581e0e
https://hg.mozilla.org/mozilla-central/rev/8252dab03823
https://hg.mozilla.org/mozilla-central/rev/1caca0678caf
https://hg.mozilla.org/mozilla-central/rev/22ed2a87b327
https://hg.mozilla.org/mozilla-central/rev/c17dd8efbeb5

Comment 46

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cac4d9e516b
Migrate histograms to use Glean APIs in netwerk/protocol/http/, r=chutten,necko-reviewers,jesup.
https://hg.mozilla.org/integration/autoland/rev/9c4caa6134f5
Migrate histograms to use Glean APIs in netwerk/protocol/websocket/, r=chutten,necko-reviewers,sunil.
https://hg.mozilla.org/integration/autoland/rev/0e21cf605bd9
Migrate histograms to use Glean APIs for NETWORK_ID* histograms, r=chutten,necko-reviewers,jesup.
https://hg.mozilla.org/integration/autoland/rev/49759b600ec0
Migrate histograms to use Glean APIs in netwerk/, r=chutten,necko-reviewers,jesup.
https://hg.mozilla.org/integration/autoland/rev/f6bbb5dcf5a3
Migrate histograms to use Glean APIs for REL_PRELOAD_MISS_RATIO, r=chutten,necko-reviewers,sunil.

Comment 47

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - fix the glean migration of the FX_SESSION_RESTORE_MANUAL_RESTORE_DURATION_UNTIL_EAGER_TABS_RESTORED_MS histogram, r=chutten.

Comment 48

[Florian Quèze [:florian]]

Attachment: Bug 1956726 - remove the scriptable Services.telemetry.getHistogramById(...).add API, r=chutten.

Comment 49

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b070f524a23
remove the now unused Telemetry::AccumulateCategorical API, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/af2229bd3e22
remove the now unused Telemetry::AccumulateTimeDelta APIs, r=chutten.

Comment 50

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b646de88c81
remove leftover Telemetry.h includes in header files, r=chutten,places-reviewers.
https://hg.mozilla.org/integration/autoland/rev/0bcdacf72290
remove leftover Telemetry.h includes in .cpp files, r=chutten,geckoview-reviewers,cookie-reviewers,win-reviewers,dom-storage-reviewers,gstoll,valentin,m_kato,janv.

Comment 51

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e76703061236
remove the now unused variants of the Telemetry::Accumulate API, r=chutten.

Comment 52

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3cac4d9e516b
https://hg.mozilla.org/mozilla-central/rev/9c4caa6134f5
https://hg.mozilla.org/mozilla-central/rev/0e21cf605bd9
https://hg.mozilla.org/mozilla-central/rev/49759b600ec0
https://hg.mozilla.org/mozilla-central/rev/f6bbb5dcf5a3

Comment 53

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7b070f524a23
https://hg.mozilla.org/mozilla-central/rev/af2229bd3e22
https://hg.mozilla.org/mozilla-central/rev/5b646de88c81
https://hg.mozilla.org/mozilla-central/rev/0bcdacf72290
https://hg.mozilla.org/mozilla-central/rev/e76703061236

Comment 54

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e32e064999d
fix the glean migration of the FX_SESSION_RESTORE_MANUAL_RESTORE_DURATION_UNTIL_EAGER_TABS_RESTORED_MS histogram, r=chutten.

Comment 55

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2e32e064999d

Comment 56

[Florian Quèze [:florian]]

Attachment: node script used to generate the migration patches

For future reference, here's the script I used to assist in generating the patches.

Comment 57

[Florian Quèze [:florian]]

I filed bug 1960567 to track separately the migration of 25 remaining keyed categorical and keyed boolean histograms (blocked on bug 1957085) as they might not be migrated during the 139 train.

Comment 58

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/358f0cf9a8d8
remove the scriptable Services.telemetry.getHistogramById(...).add API, r=chutten.

Comment 59

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/358f0cf9a8d8