1958478 - OpenPGP Key Import Info Dialog Multiple UI Issues

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement, P3)

Description

[Til Mohr]

Steps to reproduce:

Tools > OpenPGP Key Manager > File > Import Public Key(s) From File > Select some file (best, if it contains a lot of keys) > Accept & Import
Then the key import info dialog will open up.

Actual results:

Issues:

• Window is huge, and crashes Thunderbird on larger screens (common ultra wide monitors). We have heard multiple complaints from Windows and Linux/Wayland users. Also see this related issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1917284
• Window does not fit the screen, and thus ok button is not shown. Also see this related issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1832369
• List of keys is not scrollable + the "OK" button is shown at the bottom of the list -> "OK" button not on-screen
• Very long identities cause all keyboxes to be massive
• 3 column layout is clipped. Also see this related issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1904883

Also see attached images (small import = 6 keys, large import = 301 keys) - full window captures, default window size (no manual resizing).

Expected results:

• The dialog does not crash Thunderbird
• The dialog fits within the screen
• The list of keys within the dialog is scrollable
• Each keybox can be viewed in its entirety
  ** Truncate long identities (details can be viewed anyways by clicking "View Details and manage key acceptance")
• The "OK" button is always shown (on-screen), regardless of how many keys are being imported

Comment 1

[Til Mohr]

Attachment: OLD_small-import.png

Comment 2

[Til Mohr]

Attachment: OLD_small-import-with-long-names.png

Comment 3

[Til Mohr]

Attachment: OLD_large-import.png

Comment 4

[Til Mohr]

Attachment: OLD_large-import-with-long-names.png

Comment 5

[Til Mohr]

Attachment: Bug 1958478 OpenPGP key import info dialog UI fixes. r=#thunderbird-reviewers

Comment 6

[Til Mohr]

Submitted a patch. Will now submit screen shots of the new UI (using the same test files)

Comment 7

[Til Mohr]

Attachment: NEW_top.png

Comment 8

[Til Mohr]

Attachment: NEW_bottom.png

(after scrolling to the bottom of the key list)

Comment 9

[Til Mohr]

Attachment: NEW_long_names_truncated.png

Comment 10

[Til Mohr]

What is blocking this?

Our simple fixes resolve issues that hundreds of employees in our company alone are facing on a regular basis. All that needs to be done is merge.

Comment 11

[betterbird.project+18]

This works well for the import of 1, 2, 3 or more/many keys:
https://github.com/Betterbird/thunderbird-patches/blob/main/140/bugs/1958478-sizing-in-key-import-info.patch

Comment 12

[Til Mohr]

The patch from Betterbird looks good to us, we see all issues as resolved.
I will submit the Betterbird patch here with Thunderbird.

Thank you @Betterbird-Devs for taking your time to fix this :)

Comment 13

[Alessandro Castellani [:aleca]]

Attachment: Bug 1958478 - Rebuild the OpenPGP key import info dialog. r=kaie,arschmitz

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/abf0a7a1295c
Rebuild the OpenPGP key import info dialog. r=kaie,arschmitz,tobyp

Comment 15

[Alessandro Castellani [:aleca]]

Attachment: Bug 1958478 - Follow up: lint fixes. rs=bustage-fix DONTBUILD

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6079bb5c6ed4
Follow up: lint fixes.  DONTBUILD