1958771 - The "authenticatorId" is handles as a uint64 while the specification uses a non-null string made using up to 48 characters

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I noticed this issue when investigating bug 1957746. As per the WebAuthn specification the authenticatorId is a:

An non-null string made using up to 48 characters from the unreserved production defined in Appendix A of [RFC3986] that uniquely identifies the Virtual Authenticator.

But in our implementation it has a uint64_t type:
https://searchfox.org/mozilla-central/rev/e600058b50ddb4932be63d5a8926fb154398b679/dom/webauthn/nsIWebAuthnService.idl#94,105,110

As Dana mentioned on bug 1957746 comment 5 the specification may have changed after we implemented it but it was never corrected.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jschanck, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[John Schanck [:jschanck]]

Attachment: Bug 1958771 - align WebAuthn virtual authenticator `authenticatorId` with the specification. r=keeler

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a029116ae05a
align WebAuthn virtual authenticator `authenticatorId` with the specification. r=keeler,webdriver-reviewers,whimboo

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on MacOSWebAuthnService.mm

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/48fb21b04e65401ad4eab1e77e98a5717d2ad9cf
Log link: https://treeherder.mozilla.org/logviewer?job_id=505858049&repo=autoland&lineNumber=26235

There were also bustages on WinWebAuthnService.cpp

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/089c146c218a
align WebAuthn virtual authenticator `authenticatorId` with the specification. r=keeler,webdriver-reviewers,whimboo

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/089c146c218a