1957746 - All the WebAuthentication related commands are broken

Status: ASSIGNED

(Testing :: geckodriver, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When I tried to fix the serialization of WebAuthentication related commands on the Marionette side I've noticed that there are other issues as well which currently leaves nearly all the WebAuthentication commands as unusable. So that's wrong:

• We do not correctly serialize / deserialize the Authenticator and Credential parameters. This will be fixed via bug 1952944.
• We do not pass the required authenticator id via geckodriver to Marionette
• The specification defines the authenticatorId as a string but our implementation in Firefox handles it as uint64.
• Maybe others...

Via bug 1952944 I'll add a release note item which will add a new item to the known bugs section explaining that it is not usable yet. Given that we seem to have already some users at least we should get it fixed.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #0)

• The specification defines the authenticatorId as a string but our implementation in Firefox handles it as uint64.

Dana, could you please check that part and why we differ from the specification? Is that wanted?

Comment 2

[Dana Keeler (she/her) [:keeler]]

I suspect the spec changed at some point, or perhaps hadn't been finalized when the original patch that the final implementation was based on was written. In any case, we probably want to match the spec.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Dana! I filed bug 1958771.

Comment 4

[James Graham [:jgraham]]

It seems to me that we can just implement the string to int conversion in marionette, so we don't need any platform changes here.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to James Graham [:jgraham] from comment #4)

It seems to me that we can just implement the string to int conversion in marionette, so we don't need any platform changes here.

Yes, that was as well my proposal. Whenever the platform code gets updated they will have to remove the workaround in Marionette as well.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: WIP: Bug 1957746 - Fix WebAuthn implementation

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We have less capacity in M18 so moving out to M19. By then lets decide if we ignore the complications around the invalid arguments errors and only implement the sunny code paths.