1958863 - Cleanup traces of the legacy telemetry histogram API in geckoview

Status: RESOLVED FIXED

(GeckoView :: General, task)

Description

[Florian Quèze [:florian]]

widget/android/Telemetry.h implements an AddHistogram method that forwards data to Glean:

  static void AddHistogram(jni::String::Param aName, int32_t aValue) {
    MOZ_ASSERT(aName);
    nsCString name = aName->ToCString();
    if (name.EqualsLiteral("GV_STARTUP_RUNTIME_MS")) {
      glean::geckoview::startup_runtime.AccumulateRawDuration(
          TimeDuration::FromMilliseconds(aValue));
    } else if (name.EqualsLiteral("GV_CONTENT_PROCESS_LIFETIME_MS")) {
      glean::geckoview::content_process_lifetime.AccumulateRawDuration(
          TimeDuration::FromMilliseconds(aValue));
    }
  }

This is then called from https://searchfox.org/mozilla-central/rev/380b8fd795e7d96d8a5a3e6ec2b50a9f2b65854a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/TelemetryUtils.java#21,24-25,35-44 which is used twice:

• https://searchfox.org/mozilla-central/rev/380b8fd795e7d96d8a5a3e6ec2b50a9f2b65854a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/TelemetryUtils.java#21,24-25,35-44
• https://searchfox.org/mozilla-central/rev/380b8fd795e7d96d8a5a3e6ec2b50a9f2b65854a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/process/GeckoProcessManager.java#416-417,428

Comment 1

[Cathy Lu [:calu]]

Attachment: Bug 1958863 - Remove legacy telemetry API from geckoview

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/05d6f5429d64
https://hg.mozilla.org/integration/autoland/rev/194f39a91a16
Remove legacy telemetry API from geckoview r=geckoview-reviewers,chutten,owlish,nalexander

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/194f39a91a16