1959365 - WorkerScope: Implement missing IsPlayingAudio()

Status: RESOLVED FIXED

(Core :: DOM: Workers, task)

Comment 1

[Artur Iunusov]

Attachment: Bug 1959365 - WorkerScope: Implement missing IsPlayingAudio(), r=smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da20f79da6b9
WorkerScope: Implement missing IsPlayingAudio(), r=smaug

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/223401e96340
Revert "Bug 1959365 - WorkerScope: Implement missing IsPlayingAudio(), r=smaug" for causing mochitest assertion failures on nsGlobalWindowInner.h

Comment 4

[pstanciu]

Backed out for causing mochitest assertion failures on nsGlobalWindowInner.h

• Backout link
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c9095cb46a0
WorkerScope: Implement missing IsPlayingAudio(), r=smaug

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4c9095cb46a0

Comment 7

[Hamish Willee]

FF140 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/39617

Does this have any developer facing impact? I mean I can't see any IDL changes so nothing seems to be exposed in JavaScript. If this does impact developers, can you point me to a spec link. If not, I'll remove the dev-doc-needed keyword.

Comment 8

[Artur Iunusov]

This code is not impacting developers, since the dom.workers.throttling.enabled is disabled

Comment 9

[Hamish Willee]

Hi @Artur

Developers can enable dom.workers.throttling.enabled in Firefox about:config.
It is good to document the expected behaviour earlier, or at least understand what needs to be done before a feature ships.

So assuming this was enabled, does this feature have any impact on web developers? For example, what can they do differently/what interfaces can they access that they can't with this disabled? From what I can tell, this looks like the answer is nothing - its all internal to Firefox. Can you please confirm?

Comment 10

[Artur Iunusov]

impact the same as window timers throttling (dom.timeout.enable_budget_timer_throttling)

it's internal Firefox feature