1999058 - 6,300 instances of "unrecognized topic in nsGlobalWindowInner::Observe" emitted from dom/base/nsGlobalWindowInner.cpp during macosx1015-64-qr debug testing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

6,300 instances of "unrecognized topic in nsGlobalWindowInner::Observe" emitted from dom/base/nsGlobalWindowInner.cpp during macosx1015-64-qr debug testing

I added some logging locally to figure out what the topic was and ran it during the test test_fragment_play.html where it is happening most frequently (the other top tests are also media). (I'm changing this warning in bug 1999056 so that it will include the topic.) Anyways, it looks like the topic here is audio-playback. I think this is a regression from bug 1959365. That added code that checks for the topic "audio-playback", but also adds a condition about aSubject. If the latter fails, we just end up falling through and we hit the warning at the end and fail. I think it would make more sense to structure this like the other cases and deal with the entire case for this topic right here. I wouldn't expect anybody to later implement a separate case further into the file to handle audio-playback with a different subject.

6290 WARNING: unrecognized topic in nsGlobalWindowInner::Observe: file dom/base/nsGlobalWindowInner.cpp:5319

This warning shows up in 18 test suites. A few of the most prevalent:

  1126 - test-macosx1015-64-qr/debug-mochitest-media-mda-gpu mda
   985 - test-macosx1015-64-qr/debug-mochitest-media-2 mda2
   981 - test-macosx1015-64-qr/debug-mochitest-media-spi-2 mda2
   968 - test-macosx1015-64-qr/debug-mochitest-media-nogpu-2 mda2
   722 - test-macosx1015-64-qr/debug-mochitest-media-1 mda1
   698 - test-macosx1015-64-qr/debug-mochitest-media-nogpu-1 mda1
   680 - test-macosx1015-64-qr/debug-mochitest-media-spi-1 mda1
    36 - test-macosx1015-64-qr/debug-mochitest-browser-chrome-spi-nw-7 bc7
    36 - test-macosx1015-64-qr/debug-mochitest-browser-chrome-6 bc6
    12 - test-macosx1015-64-qr/debug-mochitest-browser-chrome-12 bc12

It shows up in 181 tests. A few of the most prevalent:

   288 -        dom/media/test/test_fragment_play.html
   284 -        dom/media/test/test_bug495145.html
   264 -        dom/media/test/test_playback.html
   264 -        dom/media/webspeech/synth/test/test_speech_queue.html
   240 -        dom/media/test/test_clone_media_element.html
   196 -        dom/media/test/test_play_twice.html
   160 -        dom/media/test/test_mediatrack_replay_from_end.html
   148 -        dom/media/test/test_replay_metadata.html
   148 -        dom/media/test/test_eme_waitingforkey.html
   144 -        dom/media/test/test_streams_element_capture.html

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1999058 - Don't rely on default behavior for audio-playback in nsGlobalWindowInner::Observe.

This preserves the existing behavior, except that it avoids hitting a warning
when it gets all the way to the end. Maybe this could return NS_OK instead.

Comment 2

[Andrew McCreight [:mccr8]]

This is just a little bit of warning in debug builds, so no need to backport.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e7711a0d0fb6
https://hg.mozilla.org/integration/autoland/rev/84e84b69dbfd
Don't rely on default behavior for audio-playback in nsGlobalWindowInner::Observe. r=dom-core,smaug

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/84e84b69dbfd

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mccr8, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox146 to wontfix.

For more information, please visit BugBot documentation.