In-app notifications sometimes immediately dismissed due to locale change
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird_esr128 affected, thunderbird137 affected, thunderbird138 affected, thunderbird139 fixed)
People
(Reporter: freaktechnik, Assigned: freaktechnik)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
This is an effect we've discovered through telemetry. I haven't been able to actually reproduce it. However, telemetry gives enough data for us to devise a solution that should work.
What we're seeing is that clients that weren't included by language rules normally switch their language to be eligible for a few hundred milliseconds to a few seconds. The reason I'm confident it is language that is triggering it, is that it's the only filter criteria the affected notifications have that can change at runtime. Further, most clients report different languages across pings.
I think most of them are either English or German builds (which would be the languages the affected notifications are programmed for) with different language packs installed and enabled as default by the user.
I'm not quite sure what the mechanism is that is triggering the fallback to the bundled language for a short moment, but if I had to guess it's probably a langpack update or similar.
The most robust solution seems to be to debounce the handling of active notification re-evaluation on language updates by 5 seconds or so. Since the UI language normally doesn't change during runtime this shouldn't really impact users, and if it ever will, I think this is still an acceptable amount of time to delay the update.
This can lead to some users not seeing any appeal, since this notification would trigger (even though barely being shown), which then excludes them from the tab version of the spring appeal.
|
Assignee | |
Updated•8 months ago
|
|
|
Assignee | |
Updated•8 months ago
|
|
|
Assignee | |
Comment 1•8 months ago
|
||
|
|
Assignee | |
Updated•8 months ago
|
Pushed by vineet@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/dd0835e1628b
Debounce in-app notification state update when locale changes. r=aleca
|
||
Comment 3•8 months ago
|
||
Random idea, just in case it might help you: Did you check Linux distros, how they change languages? I know they install langpacks via their own install systems, and the app has to adapt to the system language setting. It's a long shot, I have no idea whether that's the cause.
most robust solution seems to delay by 5 seconds
This is a workaround, but not robust. It may be a startup order problem. I would recommend to:
- Find what is changing the locale
- Not dismiss the notifications after a locale change, or alternatively dismiss and repeat them.
Description
•