1959780 - The first time I click into a Google Doc's comment field, the cursor is on the right end of the comment field and I can't enter text.

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: screenshot.png

If I select text in a Google Doc, click the button to add a new comment, then click in the comment popup's text field, my cursor will appear on the right edge of the text field and typing won't enter any text. See the attached screenshot.

If I click to change focus away and back to the text field, then the cursor will appear on the left as expected and text input will work.

Yannis bisected this regression to Emilo's fix for bug 1958639:

15:17.02 INFO: Last good revision: e6d4e3b73756c0847a99544db8b8c7480b11ae22
15:17.02 INFO: First bad revision: d1bc4a5a5404f308814581d7a7fb34ee75953404
15:17.02 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e6d4e3b73756c0847a99544db8b8c7480b11ae22&tochange=d1bc4a5a5404f308814581d7a7fb34ee75953404

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Reduced test-case.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1959780 - Add a missing editing host check in GetRangeForFrame. r=masayuki

This is the low risk fix, but I'm not sure I understand what this code
is doing / why are we not just returning the "inner" range for all
frames, including inlines.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1959780 - Make GetRangeForFrame() always return the inside range for non-replaced elements, not just blocks and editing hosts. r=masayuki,saschanaz

Otherwise you can't insert stuff in something like an empty
inline-block, there are tests for that luckily, yay.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9fadced05b5
Add a missing editing host check in GetRangeForFrame. r=masayuki

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec51400e8dd7
Make GetRangeForFrame() always return the inside range for non-replaced elements, not just blocks and editing hosts. r=masayuki

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c9fadced05b5
https://hg.mozilla.org/mozilla-central/rev/ec51400e8dd7

Comment 7

[Raluca Popovici, Desktop QA]

Reproducible on Nightly 139.0a1(2025-04-10) using Ubuntu 24.10 on Google Doc.
Verified as fixed using Ubuntu 24.10 on Beta 139.0b4 and the latest Nightly 140.0a1(2025-05-05) on Google Doc.