1958639 - Triple clicking on a word on wikipedia does not select the whole sentence

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Mayank Bansal]

Go to https://en.wikipedia.org/wiki/Dirichlet_integral
Search for "Mossinghoff"
When you find that word on the page, triple-click it

AR: Only that word is selected
ER: The whole sentence or line is selected.

Bisection:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9f8766e42efea809351839114d64085d7518adf9&tochange=ee653474267a8b3660c9d70f659b5f655d3ed586

Feel free to dupe.

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1603964

:emilio, since you are the author of the regressor, bug 1603964, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Reduced test-case.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1958639 - Ignore anonymous boxes and NAC for paragraph selection code. r=#layout,masayuki

The inner block of a scroller for example (::-moz-scrolled-content)
shouldn't be considered a line break.

Same for scrollbar nodes, we don't want to break on scrollbars (or
native anonymous content in general), since we can't position the caret
and such there anyways.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/099bd0ee7554
Ignore anonymous boxes and NAC for paragraph selection code. r=masayuki

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out changeset 099bd0ee7554 (Bug 1958639) for causing bc failures on browser_clipboard and browser_edit.js

Push with failures

Failure log

Backout link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1bc4a5a5404
Ignore anonymous boxes and NAC for paragraph selection code. r=masayuki

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d1bc4a5a5404

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox138 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Really old regression, probably worth letting it ride the trains