1960148 - in RTL android, swiping away a tab goes the opposite direction

Status: RESOLVED FIXED

(Firefox for Android :: Tabs, defect)

Description

[omer]

User Agent: Mozilla/5.0 (Android 14; Mobile; rv:137.0) Gecko/137.0 Firefox/137.0
Firefox for Android

Steps to reproduce:

I opened firefox for Android, pressed the tabs button and swiped a tab to the left.

Actual results:

The bug is that the animation was to the right

Expected results:

The animation should be to the left

Comment 1

[omer]

Attachment: Screen_Recording_20250412_115918_Firefox.mp4

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::Tabs' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Thanks for reporting this bug! I am able to reproduce it.

This is a regression from the swipe to dismiss rewrite. I manually changed the FeatureFlag to use the old swipe to dismiss and can no longer reproduce the bug after that

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1904906

:007, since you are the author of the regressor, bug 1904906, could you take a look?

For more information, please visit BugBot documentation.

Comment 5

[Noah Bond [:007]]

There might be something wrong with this RTL handling after the rewrite.

There is an RTL compose preview we can use to easily triage this locally.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1904906

Comment 7

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1960148 - Fix TabsTray swipe gesture for RTL languages

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9464da5d51eb
Fix TabsTray swipe gesture for RTL languages r=android-reviewers,007

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9464da5d51eb

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:npoon, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox139 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

To ensure maximal testing, we're not going to uplift this

Comment 12

[Mira Lobontiu (Android QA)]

Attachment: Record_2025-05-08-14-47-02.mp4

Verified on the latest Firefox for Android Nightly 140.0a1 from 5/7 with Oppo Find X3 Lite (Android 11), and Google Pixel 6 (Android 16).
Swiping left is correctly handled, but with some glitches.
Nick, please take a look.
Thank you!

Comment 15

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Thanks for verifying and spotting those issues Mira! I think those are pre-existing issues with the swipe gesture rewrite. They are tracked by Bug 1951931 and Bug 1959099