Closed Bug 1960608 Opened 6 months ago Closed 6 months ago

The Manage Colors button can be pressed if High Contrast is enabled with Contrast Control on Automatic

Categories

(Firefox :: Disability Access, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
139 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox137 --- unaffected
firefox138 --- wontfix
firefox139 --- verified

People

(Reporter: atrif, Assigned: eeejay)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image manage.gif

Found in

  • 138.0b7

Affected versions

  • 139.0a1 (2025-04-14)
  • 138.0b7

Tested platforms

  • Affected platforms: Windows 10x64, Ubuntu 24, macOS 12
  • Unaffected platforms: none

Preconditions

  • High contrast enabled
  • Contrast Color : Automatic

Steps to reproduce

  1. Open about:preferences#general.
  2. Click the Manage colors button from the Website appearance section.

Expected result

  • The button is disabled or not displayed.

Actual result

  • Nothing happens.

Regression range

Additional notes

  • Attached a screen recording.
Summary: The Manage Colors menu can be opened if High Contrast is enabled with Contrast Control on Automatic → The Manage Colors button can be pressed if High Contrast is enabled with Contrast Control on Automatic

:eeejay, since you are the author of the regressor, bug 1898096, could you take a look?

For more information, please visit BugBot documentation.

Flags: needinfo?(eitan)

The settings are no longer in the colors dialog but in the following
section, so the button does not do anything.

Assignee: nobody → eitan
Status: NEW → ASSIGNED

This will probably need to be uplifted to 138, but there is a string change.

Assignee: eitan → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(eitan)
Assignee: nobody → eitan
Status: NEW → ASSIGNED

We are in RC week for 138 and too late for a String change but NI'ing bolsson jic.
Can this ride 139 that goes into beta next week?

Flags: needinfo?(bolsson)

Yes - perfectly fine for 139 localizers will have a full beta-cycle.

Flags: needinfo?(bolsson)
Attachment #9480302 - Attachment description: Bug 1960608 - Remove manage colors button from appearance ovveride warning. r?#fluent-reviewers,#settings-reviewers → Bug 1960608 - Remove manage colors button from appearance override warning. r?#fluent-reviewers,#settings-reviewers
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7793ca6811c Remove manage colors button from appearance override warning. r=fluent-reviewers,settings-reviewers,Gijs,bolsson
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch

Verified fixed with Firefox 139.0a1 (2025-04-24) on Windows 10x64, macOS 12 and Ubuntu 24. The Manage colors button is no longer displayed.

The patch landed in nightly and beta is affected.
:eeejay, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(eitan)

Comment on attachment 9480302 [details]
Bug 1960608 - Remove manage colors button from appearance override warning. r?#fluent-reviewers,#settings-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: Visible bug in settings when high contrast mode is enabled
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a straightforward removal of a button and a string change.
  • String changes made/needed: Yes
  • Is Android affected?: No
Flags: needinfo?(eitan)
Attachment #9480302 - Flags: approval-mozilla-beta?

139 is moving to beta on Monday, there is nothing to uplift at this point. You should mark 138 as wontfix instead.

Comment on attachment 9480302 [details]
Bug 1960608 - Remove manage colors button from appearance override warning. r?#fluent-reviewers,#settings-reviewers

see comment 11

Attachment #9480302 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: