The Manage Colors button can be pressed if High Contrast is enabled with Contrast Control on Automatic
Categories
(Firefox :: Disability Access, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr115 | --- | unaffected |
firefox-esr128 | --- | unaffected |
firefox137 | --- | unaffected |
firefox138 | --- | wontfix |
firefox139 | --- | verified |
People
(Reporter: atrif, Assigned: eeejay)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
211.79 KB,
image/gif
|
Details | |
48 bytes,
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta-
|
Details | Review |
Found in
- 138.0b7
Affected versions
- 139.0a1 (2025-04-14)
- 138.0b7
Tested platforms
- Affected platforms: Windows 10x64, Ubuntu 24, macOS 12
- Unaffected platforms: none
Preconditions
- High contrast enabled
- Contrast Color : Automatic
Steps to reproduce
- Open about:preferences#general.
- Click the Manage colors button from the Website appearance section.
Expected result
- The button is disabled or not displayed.
Actual result
- Nothing happens.
Regression range
- This happens after bug 1898096.
Additional notes
- Attached a screen recording.
Reporter | ||
Updated•6 months ago
|
Comment 1•6 months ago
|
||
:eeejay, since you are the author of the regressor, bug 1898096, could you take a look?
For more information, please visit BugBot documentation.
Assignee | ||
Comment 2•6 months ago
|
||
The settings are no longer in the colors dialog but in the following
section, so the button does not do anything.
Updated•6 months ago
|
Assignee | ||
Comment 3•6 months ago
|
||
This will probably need to be uplifted to 138, but there is a string change.
Assignee | ||
Updated•6 months ago
|
Assignee | ||
Updated•6 months ago
|
Comment 4•6 months ago
|
||
We are in RC week for 138 and too late for a String change but NI'ing bolsson jic.
Can this ride 139 that goes into beta next week?
Comment 5•6 months ago
|
||
Yes - perfectly fine for 139 localizers will have a full beta-cycle.
Updated•6 months ago
|
Comment 7•6 months ago
|
||
bugherder |
Reporter | ||
Comment 8•6 months ago
|
||
Verified fixed with Firefox 139.0a1 (2025-04-24) on Windows 10x64, macOS 12 and Ubuntu 24. The Manage colors button is no longer displayed.
Comment 9•6 months ago
|
||
The patch landed in nightly and beta is affected.
:eeejay, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
- If no, please set
status-firefox138
towontfix
.
For more information, please visit BugBot documentation.
Assignee | ||
Comment 10•5 months ago
|
||
Comment on attachment 9480302 [details]
Bug 1960608 - Remove manage colors button from appearance override warning. r?#fluent-reviewers,#settings-reviewers
Beta/Release Uplift Approval Request
- User impact if declined/Reason for urgency: Visible bug in settings when high contrast mode is enabled
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a straightforward removal of a button and a string change.
- String changes made/needed: Yes
- Is Android affected?: No
Comment 11•5 months ago
|
||
139 is moving to beta on Monday, there is nothing to uplift at this point. You should mark 138 as wontfix instead.
Comment 12•5 months ago
|
||
Comment on attachment 9480302 [details]
Bug 1960608 - Remove manage colors button from appearance override warning. r?#fluent-reviewers,#settings-reviewers
see comment 11
Updated•5 months ago
|
Reporter | ||
Updated•5 months ago
|
Description
•