1960651 - Investigate whether we can skip the timer when wifi scan is disabled

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, task)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1960283#c1.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

So I was wondering what this cell/ip scanning is about. There was geo.cell.scan that actually did this but that's gone now by bug 1310864 (was part of B2G). So that part is moot, we should just skip this timer in that case.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1960651 - Part 1: Move all geolocation tests to dom/geolocation/test r=#dom-core

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1960651 - Part 2: Immediately trigger geolocation request when a new watcher is registered r=#dom-core

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/030a5af07944
Part 1: Move all geolocation tests to dom/geolocation/test r=dom-core,frontend-codestyle-reviewers,mccr8

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/030a5af07944

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/193b6087c98a
Part 2: Immediately trigger geolocation request when a new watcher is registered r=dom-core,mccr8

Comment 7

[pstanciu]

Backed out for causing wd failures on coordinates.py

• https://hg.mozilla.org/integration/autoland/rev/3dead9e370d017fc01d3db0524f08df72d2bc6b2
• Push with failures
• Failure Log

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

Commented in bug 1962205.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be64a463d507
Part 2: Immediately trigger geolocation request when a new watcher is registered r=dom-core,mccr8

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/be64a463d507

Comment 11

[Alexandra Borovova [:Sasha]]

We still have related failures on beta.
Do you think we can uplift these changes?

Comment 12

[Kagami Rosylight [:saschanaz] (they/them)]

Only when the regressions are fixed 😅