1960683 - Event should not be sent for Smart Tab Grouping if the user has not opted in

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Comment 1

[Vasish Baungally]

Attachment: Bug 1960683 - Prevent event from being sent for Smart Tab Grouping if not opted-in. r?rrando,dwalker

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d2f1539c87f
Prevent event from being sent for Smart Tab Grouping if not opted-in. r=tabbrowser-reviewers,sthompson

Comment 3

[Vasish Baungally]

Attachment: Bug 1960683 - Prevent event from being sent for Smart Tab Grouping if not opted-in. r?rrando,dwalker

Original Revision: https://phabricator.services.mozilla.com/D245601

Comment 4

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: No user impact, but we'll be getting telemetry for ML when the user hasn't opted in.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Turn off browser.tabs.groups.smart.optin and right click on a tab and "Add Tab to New Group". Press cancel and check that no glean event is sent Glean.tabgroup.smartTabTopic.testGetValue()
• Risk associated with taking this patch: There shouldn't be any. We have good test coverage here.
• Explanation of risk level: We should get this in, otherwise the telemetry we're getting for the Smart Tab Topic Model will be wrong. Thanks!
• String changes made/needed: No
• Is Android affected?: no

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/4d2f1539c87f

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/436747daef70