Open Bug 1939611 Opened 1 year ago Updated 3 months ago

[meta] Implement Smart Tab Groups

Categories

(Firefox :: Tabbed Browser: Tab Groups, task)

task

Tracking

()

a11y-review changes required

People

(Reporter: rrando, Unassigned)

References

(Depends on 26 open bugs)

Details

(Keywords: meta)

Meta bug for implementing Smart Tab Grouping.

Smart tab grouping is a set of features built on top of Tab Groups, using AI to automatically group open tabs and suggest labels for tab groups.

Smart Tab Grouping uses 100% local ML models to guarantee user's privacy.

See also https://mozilla-hub.atlassian.net/browse/FIDE-2441 and Vision for Smart Tab Groups

Depends on: 1939717
Depends on: 1939720
Depends on: 1939721
Depends on: 1939722
Depends on: 1939723
Depends on: 1939746
Depends on: 1939752
Depends on: 1939898
Depends on: 1939899
Blocks: 1941021
Depends on: 1944405
Depends on: 1944407
Depends on: 1946012
Depends on: 1946153
Depends on: 1946322
Depends on: 1949219
See Also: → 1951146
Depends on: 1951524
Depends on: 1951525
Depends on: 1951526

Description:
Smart tab grouping can be used for managing tabs by suggesting names for groups of tabs as well as suggesting similar tabs in a window. Testing instructions are provided below but a user would most likely use this feature when there are many tabs in the current window with a similar theme.

How do we test this?
First flip the following settings in about:config to true - browser.ml.enable and browser.tabs.groups.smart.enabled.

The "label" suggestion feature can be tested by hovering over a tab, right-clicking and selecting "Add Tab to New Group". This will download the topic model (which can take about 10-15s), and populate the tab group name field with a suggestion.

The "similar tabs" suggestion feature can be tested from the same modal that opens up after clicking "Add Tab to New Group". First open a couple of tabs with a similar theme, for example "Travel Planning". Then right-click on a tab and click on "Add Tab to New Group". This will create the modal for suggesting group label. From that modal, there's another button with "Suggest tabs to group" text. Clicking on that button should suggest the similar tabs that are in the current window. Finally click "Done" to end the flow. The new tabs should now be part of the group.

When will this ship?
Tracking bug/issue: Current bug
Design documents (e.g. Product Requirements Document, UI spec): https://www.figma.com/design/f6J2lH6XDxLxyzOLr2E8oE/Tab-Grouping-Spec?node-id=9429-240756&p=f&t=mD4GtYoMU0IQXRvI-0
Engineering lead: Rolf Rando (@rrando)
Product manager: Stefan Smagula

The accessibility team has developed the Mozilla Accessibility Release Guidelines which outline what is needed to make user interfaces accessible:
https://wiki.mozilla.org/Accessibility/Guidelines
Please describe the accessibility guidelines you considered and what steps you've taken to address them:

Describe any areas of concern to which you want the accessibility team to give special attention:

a11y-review: --- → requested
Depends on: 1952417
Depends on: 1954541
Depends on: 1954648
See Also: → 1953899
Depends on: 1957148
Depends on: 1957510
Depends on: 1959260
Depends on: 1959402
Depends on: 1961086
Depends on: 1960295
Depends on: 1956616
Depends on: 1959202
Depends on: 1962769
a11y-review: requested → assigned
Depends on: 1961511
Depends on: 1963120
Depends on: 1962228
Depends on: 1963960
Depends on: 1963963
Depends on: 1964117
Depends on: 1964124
Depends on: 1964137
Depends on: 1964178
Depends on: 1964202
Depends on: 1964204
Depends on: 1964768
Depends on: 1965024

The testing and reporting for the Smart Tab Groups in the Firefox 139 (Nightly) is completed and the list of bugs recorded is available.

Accessibility team recommends to resolve all the bug reported, starting with the following top-3 bugs (considering they are also access-S2 bugs and has to be resolved as soon as possible because they do block users with disabilities from participating in the experiment and using the feature altogether):

  1. (access-S2) Bug 1963960 - Accessibility: Smart Tab Groups suggested tabs level 2 checkboxes are not labeled programmatically
  2. (access-S2) Bug 1964202 - Accessibility: Smart Tab Group opt-in panel includes static text that is not announced by a screen reader
  3. (access-S2) Bug 1964768 - Accessibility: It is not clear for a screen reader user when there are no suggestions provided by the Smart Tab Group

Let me know if you have any questions and do not hesitate to reach out should you need any further guidance on the remediation of the bugs reported.

a11y-review: assigned → changes required
Depends on: 1966361
Depends on: 1974387
Depends on: 1976478
Depends on: 1945223
Depends on: 1978921
Depends on: 1979390
Depends on: 1982102
Depends on: 1982193
Depends on: 1958190
Depends on: 1999499
Depends on: 1970500
Depends on: 2005242
Depends on: 2009270, 2010313
No longer depends on: 2009270
No longer depends on: 2010313
Component: Tabbed Browser → Tabbed Browser: Tab Groups
Depends on: 2009270, 2010313
You need to log in before you can comment on or make changes to this bug.