1961043 - text in history sidebar invisible

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect)

Description

[Michal 'hramrach' Suchanek]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:137.0) Gecko/20100101 Firefox/137.0

Steps to reproduce:

Apply BlackMATE OS theme, open history sidebar

Actual results:

text invisible

Expected results:

text visible

Comment 1

[Michal 'hramrach' Suchanek]

Attachment: image.png

Comment 2

[Michal 'hramrach' Suchanek]

history dropdown: correct, black on white
view dropdown, history entries: bad, white on white

looking glass icon: correct, light on dark backgdound
search text: bad, black on dark

Comment 3

[Sarah Clements [:sclements] | PTO until Jan 5th]

Nothing has changed recently with regards to theming variables for the legacy sidebar AFAIK, and since we're actively rolling out the new sidebar very soon we won't be investing more into the old one.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Well this is the system theme, it also happens with the revamped sidebar.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Actually I thought this was the wrong system colors but it's not.

Comment 6

[Sarah Clements [:sclements] | PTO until Jan 5th]

Emilio, since you were able to verify this with sidebar.revamp flipped can you post a screenshot of what this looks like on the new sidebar please?

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit BugBot documentation.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

I had actually attached a patch, but seems it got stuck in draft state: https://phabricator.services.mozilla.com/D247062

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Screenshot with revamped sidebar.

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1961043 - Use the right text color for sidebar panels. r=#sidebar-reviewers

Otherwise we get -moz-dialogtext which may not have enough contrast with
the -moz-sidebar background.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1089c6f7e9f8
Use the right text color for sidebar panels. r=sidebar-reviewers,desktop-theme-reviewers,places-reviewers,dao,nsharpley,adw

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27883ab216ba
Fix browser_ext_themes_sidebars.js

Comment 13

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/1089c6f7e9f8
https://hg.mozilla.org/mozilla-central/rev/27883ab216ba

Comment 14

[Sarah Clements [:sclements] | PTO until Jan 5th]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #10)

Created attachment 9484233 [details]
Bug 1961043 - Use the right text color for sidebar panels. r=#sidebar-reviewers

Otherwise we get -moz-dialogtext which may not have enough contrast with
the -moz-sidebar background.

Ah right, bookmarks is the same for the new sidebar. Thanks for the fix!

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox139 to wontfix.

For more information, please visit BugBot documentation.

Comment 16

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9484233 [details]
Bug 1961043 - Use the right text color for sidebar panels. r=#sidebar-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency:
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: The test fix needs uplift too.
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple color change.
• String changes made/needed: none
• Is Android affected?: No

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Please submit a Beta uplift request through Phabricator for this.

Comment 18

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1961043 - Use the right text color for sidebar panels.

Otherwise we get -moz-dialogtext which may not have enough contrast with
the -moz-sidebar background.

Original Revision: https://phabricator.services.mozilla.com/D247062

Comment 19

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: see above
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See above
• Risk associated with taking this patch: low
• Explanation of risk level: scoped css tweak
• String changes made/needed: none
• Is Android affected?: no

Comment 20

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/054d989d3a32

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 22

[Giorgia Nichita, Release Desktop QA]

Attachment: Screenshot from 2025-05-05 16-54-50 (1).png

I managed to reproduce this issue on an affected nightly build after installing the MATE desktop environment and enabling the BlackMATE theme, on Ubuntu 22.04.
Verified fixed in Firefox Beta 139.0b3 and Nightly 140.0a1 with sidebar.revamp enabled. The text is now clearly visible in both the History and Bookmarks tabs, with proper contrast.

However, I’ve noticed a new issue: in the revamped sidebar, the Bookmarks tab search field has a dark background in Beta but a light background in Nightly, while the History tab search field remains white in both cases. Additionally, with the old sidebar, both search fields appear dark in Beta but white in Nightly. Which behavior is considered correct?

Since the initial issue has been fixed, I am closing this bug as verified fixed. Should I file a new bug for the search field styling issue, or is it already being tracked?

Comment 23

[Emilio Cobos Álvarez [:emilio]]

That's expected, see bug 1963446 comment 7.