1963446 - More clean-ups to nsNativeThemeGTK

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1963446 - Use non-native textfields on Linux. r=stransky

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1963446 - Remove unused appearance: dualbutton. r=stransky

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1963446 - Remove unused button-arrow-{previous,next} appearance values. r=stransky

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1963446 - Use non-native buttons on Linux. r=stransky

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1963446 - Unify button.css between Linux and Windows. r=#theme

Remove unneeded dropmarker rule. The default dropmarker already draws a
nice arrow from the non-native theme (the same <select> uses).

Comment 6

[Dão Gottwald [:dao]]

I'd appreciate a bit more context for this bug. I understand that Firefox itself has very few surfaces left that sort of look like native windows, such as the page info window. So at this point, for secondary and arguably legacy UI, I can see why we wouldn't care as much about maintaining this, and perhaps that's all that matters here. That said, I'd like to explicitly ask about other Gecko and toolkit consumer(s?) such as Thunderbird. Might they have more such surfaces? Are we sure it's a good idea to drop native button and textbox appearances across the board?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Yeah, fair ask. Context is:

• What you mentioned (lots of code for secondary / legacy UI).
• Our code to match the native theme is not always particularly great. Some themes show very ugly widgets, see for example bug 1961043 comment 9 for a native textfield with the GTK theme from that user.
• Simplifies eventually porting to GTK 4, which doesn't support native widget drawing anyways.

Note that the native appearance is not fully gone (we still use native colors to render the widgets).

I'm also not opposed to do something a bit more native-looking than what this bug is doing by tweaking colors / spacing / borders / etc, but I think trying to match arbitrary GTK themes using the GTK3 native widget painting is not great. Even for common GTK themes our current styling looks out of date (GTK has moved on to flatter buttons etc).

That is: The "non-native" Firefox UI buttons and so on look more "native" in a GTK environment than the current GTK3 buttons with themes like Adwaita. (Breeze regresses a bit, which is a bit unfortunate but...)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8497b88a6ea8
Use non-native textfields on Linux. r=stransky,desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/9f94042ce165
Remove unused appearance: dualbutton. r=stransky
https://hg.mozilla.org/integration/autoland/rev/8ddfaf47567f
Remove unused button-arrow-{previous,next} appearance values. r=stransky
https://hg.mozilla.org/integration/autoland/rev/f1e8a46d4868
Use non-native buttons on Linux. r=stransky,desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/34410bd3a248
Unify button.css between Linux and Windows. r=desktop-theme-reviewers,dao

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9f16f4f3164
Revert Bug 1963446 - Unify button.css between Linux and Windows. r=desktop-theme-reviewers,dao

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/875c72db8da5
Use non-native textfields on Linux. r=stransky,desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/68aecd7fdfbb
Remove unused appearance: dualbutton. r=stransky
https://hg.mozilla.org/integration/autoland/rev/e914dd0b1037
Remove unused button-arrow-{previous,next} appearance values. r=stransky
https://hg.mozilla.org/integration/autoland/rev/d60844bece50
Use non-native buttons on Linux. r=stransky,desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/45f15f23a48b
Unify button.css between Linux and Windows. r=desktop-theme-reviewers,dao

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/875c72db8da5
https://hg.mozilla.org/mozilla-central/rev/68aecd7fdfbb
https://hg.mozilla.org/mozilla-central/rev/e914dd0b1037
https://hg.mozilla.org/mozilla-central/rev/d60844bece50
https://hg.mozilla.org/mozilla-central/rev/45f15f23a48b