Closed Bug 1961412 Opened 4 months ago Closed 4 months ago

Improve the dismissal API

Categories

(Application Services :: Suggest, task, P1)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: adw, Assigned: adw)

References

Details

(Whiteboard: [sng])

Attachments

(1 file)

Desktop currently uses its own dismissal implementation, and we'd like to switch over to suggest to take advantage of its new dismissal-key system for AMP geo expansion. We need a couple of dismissal methods that SuggestStore doesn't have:

  • dismiss_by_key - This will let us store dismissed Merino suggestions in SuggestStore.
  • is_suggestion_dismissed_by_key - This will let us know whether a Merino suggestion has been dismissed.
  • any_dismissed_suggestions - The settings UI has a button that clears dismissals, and it's disabled if there are no dismissed suggestions. That's a nice UI that we want to carry forward when switching to SuggestStore dismissals.
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Flags: qe-verify+
Resolution: --- → FIXED
See Also: → 1961701
Blocks: 1961881
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: