Closed
Bug 1961412
Opened 4 months ago
Closed 4 months ago
Improve the dismissal API
Categories
(Application Services :: Suggest, task, P1)
Application Services
Suggest
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: adw, Assigned: adw)
References
Details
(Whiteboard: [sng])
Attachments
(1 file)
Desktop currently uses its own dismissal implementation, and we'd like to switch over to suggest
to take advantage of its new dismissal-key system for AMP geo expansion. We need a couple of dismissal methods that SuggestStore
doesn't have:
dismiss_by_key
- This will let us store dismissed Merino suggestions inSuggestStore
.is_suggestion_dismissed_by_key
- This will let us know whether a Merino suggestion has been dismissed.any_dismissed_suggestions
- The settings UI has a button that clears dismissals, and it's disabled if there are no dismissed suggestions. That's a nice UI that we want to carry forward when switching toSuggestStore
dismissals.
Updated•4 months ago
|
Comment 1•4 months ago
|
||
Comment 2•4 months ago
|
||
Authored by https://github.com/0c0w3
https://github.com/mozilla/application-services/commit/41e0b8f5679977ff2f551eb60fa9b3288ce1f2d8
[main] Bug 1961412 - Improve the Suggest dismissal API.
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Flags: qe-verify+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•