1961829 - Incorrect coloration of non http URLs in Android URLRenderer when ColoredUrl ToolbarFeature is enabled

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Michel Le Bihan]

Steps to reproduce

1. Apply the patch from https://phabricator.services.mozilla.com/D244509 to enable the ColoredUrl ToolbarFeature
2. Navigate to about:mozilla or open a PDF file in Fenix
3. Navigate to http://localhost/

Expected behavior

I'm not sure and feedback would be very appreciated.

content:// URIs should probably not be colored at all.

about:mozilla should either not be colored at all or have the URL primary (textPrimary) color.

localhost should have the URL primary (textPrimary) color and colorRegistrableDomain should color the entire domain if it can't infer the registrable domain (eTLD+1).

Actual behavior

about:mozilla, the entire content:// URI when opening a PDF file and localhost all have the URL secondary (textSecondary) color.

Device information

• Firefox version: 139 with patch enabling feature
• Android device model: Sony Xperia 5 V
• Android OS version: 15

Any additional information?

Comment 1

[Michel Le Bihan]

Attachment: Bug 1961829 - Only color HTTP(S) URIs and fallback to coloring the host in Android toolbar URLRenderer. r=tthibaud

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5eb2ecdb616
Only color HTTP(S) URIs and fallback to coloring the host in Android toolbar URLRenderer. r=tthibaud,android-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a5eb2ecdb616