Change code that depended on events reaching text nodes

NEW

Status

()

Core
DOM: Events
15 years ago
8 years ago

People

(Reporter: Heikki Toivonen (remove -bugzilla when emailing directly), Assigned: John Keiser (jkeiser))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

One such bug that was just fixed is bug 195886.

I searched LXR for ".parentNode", and then manually for instances where "event"
also appeared and came up with these. Please note that this is still not an
exhaustive list of possible problem spots (I did not catch variable usage for
example, nor C/C++ code):

http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/nsDragAndDrop.js#114
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EdImageMapShapes.js#517
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EdImageMapShapes.js#529
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EdImageMapShapes.js#617
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EdImageMapShapes.js#619
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EdImageMapShapes.js#620
http://lxr.mozilla.org/seamonkey/source/rdf/resources/dom-test-1.xul#95
http://lxr.mozilla.org/seamonkey/source/rdf/resources/dom-test-2.xul#95
http://lxr.mozilla.org/seamonkey/source/rdf/resources/dom-test-3.xul#53
(tests 4, 6 and 8 probably have incorrect usage as well)
http://lxr.mozilla.org/seamonkey/source/rdf/resources/ignore-test.xul#31
http://lxr.mozilla.org/seamonkey/source/rdf/resources/xpidl-test-1.xul#34
John, I seem to recall that you made this change. Did you make an attempt to fix
all the callers that depended on the old behavior?
Hmm, I read my last comment again and I realized it came out differently than I
intended. Sincere apologies, John! I filed this bug to help you find any
remaining issues, not to bash you or anything like that.
Assignee: saari → jkeiser
(Assignee)

Comment 3

15 years ago
I didn't read any bashing into it ... I didn't check all callers, no, just a
rather small sampling and using the browser for a while.  Most of the links here
given are benign (not related to textnode targeting).  I haven't gone through
them all yet.
QA Contact: desale → events
You need to log in before you can comment on or make changes to this bug.