1962500 - Set limit on the column breakpoint markers that are rendered

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Hubert Boma Manilla (:bomsy)]

Lets add a limit on the number of column breakpoint markers, this mostly helps improve really large minified sources where adding a. breakpoint on the line will add column breakpoint markers at all the possible positions on that line. Most of these positions might not be interesting to users, but rendering all the markers has an impact on debugger performance (especially when scrolling those larger sources).

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1962500 - [devtools] Set max limit on the displayed column breakpoint markers r=#devtools

• A max limit is set on the amount of column breatpoint markers rendered
• Fix bug to correctly determine the start and end locations of the viewport

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d81f9901c46a
[devtools] Set max limit on the displayed column breakpoint markers r=devtools-reviewers,nchevobbe

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d81f9901c46a

Comment 4

[Florin Bilt]

(In reply to Cosmin Sabou [:CosminS] from comment #3)

https://hg.mozilla.org/mozilla-central/rev/d81f9901c46a

Perfherder has detected a devtools performance change from push d81f9901c46a37bdef6ae721d77880fd37679bea.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
36%	damp custom.jsdebugger.with-wrap-editor.add-breakpoint.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	482.19 -> 309.45
29%	damp custom.jsdebugger.with-wrap-editor.add-breakpoint.DAMP	macosx1470-64-shippable	e10s fission stylo webrender	368.92 -> 262.87
26%	damp custom.jsdebugger.with-wrap-editor.add-breakpoint.DAMP	windows11-64-24h2-shippable	e10s fission stylo webrender	233.14 -> 172.06

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 44900

The following documentation link provides more information about this command.