1946026 - CM6 performance issue when setting breakpoint on bundle

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Julian Descottes [:jdescottes]]

STRs:

• open tab on https://www.pgecorp.com/
• open debugger
• open source https://cdn.cookielaw.org/scripttemplates/202411.2.0/otBannerSdk.js
• set a breakpoint

AR: Setting the breakpoint will be slow, be will succeed after a few seconds. However trying to scroll in the editor (with line wrapping enabled) made my browser hang for minutes, I had to kill the process.

Compared to CM5, it seems we used to limit the buffer of text which would be using syntax highlighting, whereas now we apply it everywhere. On top of this we render column breakpoints in the whole text, whereas in CM5 it seems we stop rendering them quite quickly for those very long lines

Comment 1

[Julian Descottes [:jdescottes]]

https://share.firefox.dev/3EsKmdt

Bomsy will take a look

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1946026 - [devtools] Optimize the column rendering of the breakpoints r=#devtools

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1946026 - [devtools] Fix to get the correct viewport dimensions r=#devtools

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9378cd62358
[devtools] Optimize the column rendering of the breakpoints r=devtools-reviewers,ochameau

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d9378cd62358

Comment 6

[Phabricator Automation]

Comment on attachment 9477470 [details]
Bug 1946026 - [devtools] Fix to get the correct viewport dimensions r=#devtools

Revision D244594 was moved to bug 1962500. Setting attachment 9477470 [details] to obsolete.