1962757 - For SERP telemetry, allow fields within cookies to be in any part of the field

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

Currently when checking the SERP for follow-ons, we require that the parameter within the cookie is at the start of the cookie. This might not be correct and depends on the third party. We should make it more flexible, as Android has already done (bug 1932178).

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1962757 - For SERP telemetry, allow fields within cookies to be in any part of the field. r?#search-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b0705a51a59
For SERP telemetry, allow fields within cookies to be in any part of the field. r=search-reviewers,scunnane

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/1b0705a51a59

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1962757 - For SERP telemetry, allow fields within cookies to be in any part of the field.

Original Revision: https://phabricator.services.mozilla.com/D246956

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: None, telemetry-only change, needed to fix some telemetry reporting for search engine result pages.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Search QA already have STR
• Risk associated with taking this patch: Low
• Explanation of risk level: Small self-contained change to telemetry recording.
• String changes made/needed: None
• Is Android affected?: no

Comment 8

[Mark Banner (:standard8)]

Attachment: Bug 1962757 - For SERP telemetry, allow fields within cookies to be in any part of the field.

Original Revision: https://phabricator.services.mozilla.com/D246956

Comment 9

[Mark Banner (:standard8)]

Attachment: Bug 1962757 - For SERP telemetry, allow fields within cookies to be in any part of the field.

Original Revision: https://phabricator.services.mozilla.com/D246956

Comment 10

[Phabricator Automation]

firefox-esr128 Uplift Approval Request

• User impact if declined: None, telemetry-only change, needed to fix some telemetry reporting for search engine result pages.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Search QA already have STR
• Risk associated with taking this patch: Low
• Explanation of risk level: Small self-contained change to telemetry recording.
• String changes made/needed: None
• Is Android affected?: no

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e61ffb2cc107

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/323f5b3458f9

Comment 13

[Cristian Baica [:cbaica], Release Desktop QA]

Issue is verified fixed part of the testing activities for bug 1962763, on nightly, beta and ESR builds. Please note that for ESR an intermediary treeherder build was used for verification.