1962931 - Light/dark toggle for the dark reader mode scrolls message to the top

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, enhancement, P3)

Description

[LorenAmelang]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/134.0.0.0 Safari/537.36

Steps to reproduce:

I need to use the light/dark toggle on about every other message, to make the dimmest chars sort of visible. Every time I touch it, it grabs focus from the message, and scrolls the message to its top (where I often can't see the problem parts). I have to click back into the message body, and scroll to the problem text to see if it is better. And often go back to the previous toggle setting. (Why must modern eMails be so "fashionable"?

Actual results:

Extra clicks and scrolling.

Expected results:

Clicking the light/dark toggle should leave the message scroll where it is, and leave focus on the body text!

Comment 1

[Wayne Mery (:wsmwk)]

Perhaps this is already on your radar.

Comment 2

[Alessandro Castellani [:aleca] - PTO until Nov 16]

Thanks for the report.
The toggle needs to reload the message in order to properly clear the styling.
I think I can move the focus back to the message body, and try to restore the correct scrolling height.

Comment 3

[Alessandro Castellani [:aleca] - PTO until Nov 16]

Attachment: Bug 1962931 - Move focus back to message pane and restore scroll position after light/dark toggle. r=#thunderbird-reviewers

Comment 4

[Alessandro Castellani [:aleca] - PTO until Nov 16]

I fixed it, and also added tests for it.
When the patch lands, the message will maintain its scrolling position if the dark/light toggle is used, and the focus will move back to the message content so keyboard navigation can be used right away.

Comment 5

[Alessandro Castellani [:aleca] - PTO until Nov 16]

Release Note Request (optional, but appreciated)
[Why is this notable]: Improvements to the usability of the dark message mode switcher.
[Suggested wording]: When using the dark message mode toggle in the message header, the focus will move back to the message body and any existing scrolling position will be restored, making it easier to maintain the reading flow uninterrupted even when needing to switch between light and dark mode.
[Links (documentation, blog post, etc)]: -

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cdfbefb613a1
Move focus back to message pane and restore scroll position after light/dark toggle. r=mkmelin

Comment 7

[Corey Bryant]

Thanks for the relnote. I updated it a bit to shorten it up and put in past tense: "Toggling dark message mode did not restore focus and scroll position"