1963120 - Update Nimbus Recipes for Smart Tab Grouping

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[Vasish Baungally]

All the smart tab grouping nimbus parameters should be under smartTabGroups. Add remaining ones below:

1. Suggest other tab methods
2. Topic and Embedding model revisions
3. Threshold for Nearest Neighbor implementation

Comment 1

[Vasish Baungally]

Attachment: Bug 1963120 - Update Nimbus Recipe for Smart Tab Groups. r?rrando,mardak

New Parameters Added:

1. Suggest Other Tabs Methods
2. Topic and Embedding Model Revisions
3. Nearest Neighbor Threshold

Comment 2

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: add more smart tab grouping experimentation capability if 138 experiment is successful

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/015da2274422
Update Nimbus Recipe for Smart Tab Groups. r=rrando,Mardak,tabbrowser-reviewers

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/015da2274422

Comment 5

[Vasish Baungally]

Attachment: Bug 1963120 - Update Nimbus Recipe for Smart Tab Groups. r?rrando,mardak

New Parameters Added:

1. Suggest Other Tabs Methods
2. Topic and Embedding Model Revisions
3. Nearest Neighbor Threshold

Original Revision: https://phabricator.services.mozilla.com/D246968

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Shouldn't be any but we won't be able to test improvements to smart tab grouping via nimbus
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Turn on smart tab grouping via browser.tabs.groups.smart.enabled and then update browser.tabs.groups.smart.suggestOtherTabsMethod to LOGISTIC_REGRESSION. Go through the smart tab suggest flow by right clicking on a tab and "Add Tab to New Group". Finish the flow and if there are similar tabs in the window, those should be suggested.
• Risk associated with taking this patch: Shouldn't be any. It's just nimbus configs.
• Explanation of risk level: Not much here. It's been tested in experimenter and works.
• String changes made/needed: No
• Is Android affected?: no

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/096a0389306f