Closed Bug 1963483 Opened 1 year ago Closed 1 year ago

Perma snap mozbuild.repackaging.desktop_file.RemoteVCSError: Missing linuxDesktopEntry.ftl for cy: received HTTP 429 for GET https://raw.githubusercontent.com/mozilla-l10n/firefox-l10n/<...>/cy/browser/browser/linuxDesktopEntry.ftl

Categories

(Release Engineering :: General, defect, P1)

Tracking

(firefox141 fixed)

RESOLVED FIXED
Tracking Status
firefox141 --- fixed

People

(Reporter: smolnar, Assigned: gerard-majax)

References

Details

Attachments

(1 external file)

Push with failures

Failure log

Creating the 'repackage-desktop-file' site at /builds/worker/firefox-snap/parts/firefox/build/.mozbuild/srcdirs/build-0996710f2f4f/_virtualenvs/repackage-desktop-file
[task 2025-04-29T16:13:10.850Z] :: Error running mach:
[task 2025-04-29T16:13:10.850Z] ::
[task 2025-04-29T16:13:10.850Z] ::     mach repackage desktop-file --output /builds/worker/firefox-snap/parts/firefox/install/firefox.desktop --flavor snap --release-product firefox --release-type nightly
[task 2025-04-29T16:13:10.850Z] ::
[task 2025-04-29T16:13:10.850Z] :: The error occurred in code that was called by the mach command. This is either
[task 2025-04-29T16:13:10.850Z] :: a bug in the called code itself or in the way that mach is calling it.
[task 2025-04-29T16:13:10.850Z] :: You can invoke ``./mach busted`` to check if this issue is already on file. If it
[task 2025-04-29T16:13:10.850Z] :: isn't, please use ``./mach busted file repackage`` to report it. If ``./mach busted`` is
[task 2025-04-29T16:13:10.850Z] :: misbehaving, you can also inspect the dependencies of bug 1543241.
[task 2025-04-29T16:13:10.850Z] ::
[task 2025-04-29T16:13:10.850Z] :: If filing a bug, please include the full output of mach, including this error
[task 2025-04-29T16:13:10.850Z] :: message.
[task 2025-04-29T16:13:10.850Z] ::
[task 2025-04-29T16:13:10.850Z] :: The details of the failure are as follows:
[task 2025-04-29T16:13:10.851Z] ::
[task 2025-04-29T16:13:10.851Z] :: mozbuild.repackaging.desktop_file.RemoteVCSError: Missing linuxDesktopEntry.ftl for cy: received HTTP 429 for GET https://raw.githubusercontent.com/mozilla-l10n/firefox-l10n/1f26f0ee295ce9937c8a19dced593845c60b6575/cy/browser/browser/linuxDesktopEntry.ftl
[task 2025-04-29T16:13:10.851Z] ::
[task 2025-04-29T16:13:10.851Z] ::   File "/builds/worker/firefox-snap/parts/firefox/build/python/mozbuild/mozbuild/mach_commands.py", line 3475, in repackage_desktop_file
[task 2025-04-29T16:13:10.851Z] ::     desktop = SnapDesktopFile(
[task 2025-04-29T16:13:10.851Z] ::               ^^^^^^^^^^^^^^^^
[task 2025-04-29T16:13:10.851Z] ::   File "/builds/worker/firefox-snap/parts/firefox/build/python/mozbuild/mozbuild/repackaging/snapcraft_transform.py", line 160, in __init__
[task 2025-04-29T16:13:10.851Z] ::     self.desktop = generate_browser_desktop_entry(
[task 2025-04-29T16:13:10.851Z] ::                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2025-04-29T16:13:10.851Z] ::   File "/builds/worker/firefox-snap/parts/firefox/build/python/mozbuild/mozbuild/repackaging/desktop_file.py", line 50, in generate_browser_desktop_entry
[task 2025-04-29T16:13:10.851Z] ::     localizations = _create_fluent_localizations(
[task 2025-04-29T16:13:10.851Z] ::                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2025-04-29T16:13:10.851Z] ::   File "/builds/worker/firefox-snap/parts/firefox/build/python/mozbuild/mozbuild/repackaging/desktop_file.py", line 124, in _create_fluent_localizations
[task 2025-04-29T16:13:10.851Z] ::     raise RemoteVCSError(mgs.format(**params))
[task 2025-04-29T16:13:10.941Z] 'override-build' in part 'firefox' failed with code 1.
[task 2025-04-29T16:13:10.941Z] Detailed information: 
[task 2025-04-29T16:13:10.941Z] :: + rm -rf /builds/worker/firefox-snap/parts/wasi-sdk//src
[task 2025-04-29T16:13:10.941Z] :: + MACH='/usr/bin/python3 ./mach'
[task 2025-04-29T16:13:10.941Z] :: + /usr/bin/python3 ./mach repackage desktop-file --output /builds/worker/firefox-snap/parts/firefox/install/firefox.desktop --flavor snap --release-product firefox --release-type nightly
[task 2025-04-29T16:13:10.944Z] Recommended resolution: Review the scriptlet and make sure it's correct.
[task 2025-04-29T16:13:10.944Z] For more information, check out: https://canonical-snapcraft.readthedocs-hosted.com/en/8.8.1/reference/plugins.html
[task 2025-04-29T16:13:10.944Z] Full execution log: '/builds/worker/.local/state/snapcraft/log/snapcraft-20250429-160004.954049.log'
[taskcluster 2025-04-29 16:13:13.231Z] === Task Finished ===
[taskcluster 2025-04-29 16:13:13.778Z] Unsuccessful task run with exit code: 1 completed in 1094.13 seconds
Flags: needinfo?(lissyx+mozillians)

Looks like github was unhappy? I see many reports on the internet at a similar time yesterday

Assignee: nobody → lissyx+mozillians
Flags: needinfo?(lissyx+mozillians)

Green after retries

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME

This is still an intermittent issue, can we keep this bug open for classification?

Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---

Could you take a look at this recent spike in failures?

Recent failure log -> https://treeherder.mozilla.org/logviewer?job_id=508573812&repo=autoland

Flags: needinfo?(lissyx+mozillians)

that's github, nothing i can do

Flags: needinfo?(lissyx+mozillians)

429 means we're hitting rate limits.
https://github.blog/changelog/2025-05-08-updated-rate-limits-for-unauthenticated-requests/ probably doesn't help.

Component: Third Party Packaging → General
Product: Firefox Build System → Release Engineering

Bug 1824327 introduced _create_fluent_localizations() and at that time, it fetched strings from hg.mozilla.org[1]. Bug 1900421 switched the repo to its GitHub equivalent. Given that repo is public, we didn't require any authentication.

As :jcristau said in comment 8, the root cause is the new GitHub policy for unauthenticated requests. I understand the fix is to make _create_fluent_localizations() use authenticated requests.

[1] https://hg-edge.mozilla.org/mozilla-central/rev/f9bda84dbaf72d3e41b8aeed9277a47baa3bdf33#l14.184

Depends on: 1900421, 1824327
Summary: Intermittent snap [Tier 2] mozbuild.repackaging.desktop_file.RemoteVCSError: Missing linuxDesktopEntry.ftl for cy: received HTTP 429 for GET https://raw.githubusercontent.com/mozilla-l10n/firefox-l10n/<...>/cy/browser/browser/linuxDesktopEntry.ftl → Perma snap mozbuild.repackaging.desktop_file.RemoteVCSError: Missing linuxDesktopEntry.ftl for cy: received HTTP 429 for GET https://raw.githubusercontent.com/mozilla-l10n/firefox-l10n/<...>/cy/browser/browser/linuxDesktopEntry.ftl
Severity: -- → S2
Priority: -- → P1
Depends on: 1967217

Full repo is ~1GB. I'm not sure we want to clone that much?

Attachment #9490053 - Attachment description: WIP: Bug 1963483 - Use git clone instead of raw download for l10n sourcing when producing .desktop file → Bug 1963483 - Use git clone instead of raw download for l10n sourcing when producing .desktop file r?#releng-reviewers!
Pushed by alissy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56b1564a4a4d Use git clone instead of raw download for l10n sourcing when producing .desktop file r=releng-reviewers,ahal,bhearsum
Pushed by amarc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d7444b81c07c Revert "Bug 1963483 - Use git clone instead of raw download for l10n sourcing when producing .desktop file r=releng-reviewers,ahal,bhearsum" for causing py3 failures @ test_deb.py

Backed out for causing py3 failures @ test_deb.py

Flags: needinfo?(lissyx+mozillians)
Flags: needinfo?(lissyx+mozillians)
Pushed by alissy@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0e5fc7751588 https://hg.mozilla.org/integration/autoland/rev/be6674e3541f Use git clone instead of raw download for l10n sourcing when producing .desktop file r=releng-reviewers,ahal,bhearsum
Status: REOPENED → RESOLVED
Closed: 1 year ago → 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: