1900421 - flip l10n strings to https://github.com/mozilla-l10n/firefox-l10n

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: L10N, task)

Description

[[e-mail] (:bhearsum)]

This bug tracks flipping the switch to pull strings for builds/repacks from github, and switching l10n bumper + merge automation to fetch the latest revision from github when bumping l10n-changesets.json.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Bug 1900421: flip l10n strings to new github repository r?#releng-reviewers!,eemeli!

This patch contains everything we need to flip all the l10n consumers in the tree to the new github repository:

• Enable fetching strings for builds (desktop_l10n.py for Desktop, android-mozharness-build.json for Android)
• l10n bumper (l10n-bump/kind.yml)
• merge automation (merge-automation/kind.yml)
• deb repackages (repackaging/deb.py)
• Switch l10n-changesets files to git refs to avoid breaking repacks before l10n bumper runs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/c019241cc223
flip l10n strings to new github repository r?#releng-reviewers!,eemeli!

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c019241cc223

Comment 4

[[e-mail] (:bhearsum)]

Attachment: [beta] flip l10n strings to new github repository

Approval Request Comment
[Feature/Bug causing the regression]: none
[User impact if declined]: none
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: tested already on nightly
[String changes made/needed]: none

Comment 5

[[e-mail] (:bhearsum)]

(In reply to [e-mail] (:bhearsum) from comment #4)

Created attachment 9407363 [details] [diff] [review]
[beta] flip l10n strings to new github repository

Approval Request Comment
[Feature/Bug causing the regression]: none
[User impact if declined]: none
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: tested already on nightly
[String changes made/needed]: none

One thing I should add: because this is touching l10n-changesets.json it is very likely to bitrot quickly. If that happens before this is uplifted please feel free to ping me and I can provide an updated patch when we're ready to land it.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: Bug 1900421: Switch l10n string fetching to github

Comment 7

[Phabricator Automation]

esr115 Uplift Approval Request

• User impact if declined: none
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: already tested and verified in nightly; patches applied more or less cleanly
• String changes made/needed: no
• Is Android affected?: no

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9407363 [details] [diff] [review]
[beta] flip l10n strings to new github repository

hg can't import this:

applying https://bug1900421.bmoattachments.org/attachment.cgi?id=9407363
abort: bad hunk #14: incomplete hunk
(check that whitespace in the patch has not been mangled)

Comment 9

[[e-mail] (:bhearsum)]

Attachment: Bug 1900421: flip l10n strings to new github repository

Comment 10

[[e-mail] (:bhearsum)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)

Comment on attachment 9407363 [details] [diff] [review]
[beta] flip l10n strings to new github repository

hg can't import this:

applying https://bug1900421.bmoattachments.org/attachment.cgi?id=9407363
abort: bad hunk #14: incomplete hunk
(check that whitespace in the patch has not been mangled)

I have no idea what happened here...in any case, here's a phab revision that I expect will work, and is rebased against the latest beta: https://phabricator.services.mozilla.com/D213957

Comment 11

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: none
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: tested already on nightly
• String changes made/needed: none
• Is Android affected?: no

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/78dc72313bce

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/0b3db56775fc

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/2185b3420260