Closed Bug 1963835 Opened 11 months ago Closed 9 months ago

[Feature Callout] Styling configurations to better support multiple MultiSelect tiles

Categories

(Firefox :: Messaging System, task, P1)

task
Points:
3

Tracking

()

VERIFIED FIXED
142 Branch
Iteration:
142.2 - Jul 7 - Jul 18
Tracking Status
firefox142 --- verified

People

(Reporter: mjung, Assigned: mjung)

References

(Blocks 1 open bug)

Details

(Whiteboard: [omc])

Attachments

(3 files)

We've added the ability to support multiple MultiSelect tiles within the same screen in 1952335. We'd like to leverage this in Feature Callout but we'll need to update the styling/ add some additional configuration. See attached mock up design and the current off-train solution.

As part of this work, or in a follow-up bug, we may want to unify the methods we have for handling "tile" styles across arrays of tiles and single tiles (while maintaining backwards compatibility).

We use tile.style here in ContentTiles.jsx and tiles.style here in Multiselect.jsx (only works with single tile definitions of content.tiles).

Severity: -- → N/A
Iteration: --- → 141.1 - May 26 - Jun 6
Points: --- → 3
Priority: -- → P2
Iteration: 141.1 - May 26 - Jun 6 → 141.2 - Jun 9 - Jun 20
Iteration: 141.2 - Jun 9 - Jun 20 → 142.1 - Jun 23 - Jul 4
Assignee: nobody → nsauermann
Priority: P2 → P1
Iteration: 142.1 - Jun 23 - Jul 4 → 142.2 - Jul 7 - Jul 18
Attachment #9498680 - Attachment description: Bug 1963835 - Adds mini layout and style configuration to multiple MultiSelect tiles → Bug 1963835 - Adds style configurations and support for multiple MultiSelect tiles for Feature Callout
Attachment #9498680 - Attachment description: Bug 1963835 - Adds style configurations and support for multiple MultiSelect tiles for Feature Callout → Bug 1963835 - Adds mini layout and style configuration to multiple MultiSelect tiles
Flags: qe-verify+
Pushed by nsauermann@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0134df854eb0 https://hg.mozilla.org/integration/autoland/rev/090bf21a5e08 Adds mini layout and style configuration to multiple MultiSelect tiles r=omc-reviewers,mviar
Pushed by chorotan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/73f4f03c718e https://hg.mozilla.org/integration/autoland/rev/fe9ff4b2ae85 Revert "Bug 1963835 - Adds mini layout and style configuration to multiple MultiSelect tiles r=omc-reviewers,mviar" for causing xpcshell failures on test_PanelTestProvider.js

Backed out for causing xpcshell failures on test_PanelTestProvider.js and node failure

Backout link

Push with failures

Failure log xpcshell
Failure log node

Flags: needinfo?(nsauermann)

Sorry about that, looks like I forgot to update the test_PanelTestProvider.js message count after adding the new one.

Flags: needinfo?(nsauermann)
Pushed by nsauermann@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0228ad2125de https://hg.mozilla.org/integration/autoland/rev/939fe475e79f Adds mini layout and style configuration to multiple MultiSelect tiles r=omc-reviewers,mviar
Pushed by amarc@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6ba59b3f7038 https://hg.mozilla.org/integration/autoland/rev/2aad04a53208 Revert "Bug 1963835 - Adds mini layout and style configuration to multiple MultiSelect tiles r=omc-reviewers,mviar" for causing node failures

Backed out for causing node failures

Flags: needinfo?(nsauermann)
Pushed by nsauermann@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1381e1c79253 https://hg.mozilla.org/integration/autoland/rev/2036cf433cf9 Adds mini layout and style configuration to multiple MultiSelect tiles r=omc-reviewers,mviar
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
Flags: needinfo?(nsauermann)

I have verified this issue using the latest Firefox Nightly 142.0a1 (Build ID: 20250720210720) build on Windows 10 x64, macOS 15.5, and Ubuntu 24.04.1.

  • After following the steps outlined in the test plan, I confirm that the content on the “TEST_MULTI_TILES_SURVEY” message is left-aligned and visually more refined compared to the “Current state within feature callout” image attached.
  • The message contains the following elements:
    • A fox icon and a bold “Test title” positioned at the top of the message.
    • A dismiss “x” button displayed in the upper-right corner.
    • A bold description text “Answer two questions!” placed below the title.
    • “Question 1” in bold, followed by 4 checkboxes.
    • “Question 2” in bold, followed by 2 checkboxes.
    • A blue “Submit” button that is active even when no checkboxes are selected.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: