1964120 - Remove redundant `aConstrainBSize` flag in `FinishReflowWithAbsoluteFrames` and `ReflowAbsoluteFrames`

Status: RESOLVED FIXED

(Core :: Layout: Positioned, enhancement)

Description

[David Shin[:dshin]]

By definition, when anchor positioned abspos element is being reflowed, its abspos containing block's rect is not set - For example, here the abspos reflow happens for the abspos containing block and then its size is saved later on at an upper level.

To figure out the offset of the anchor from any axis, we need this value.

Comment 1

[David Shin[:dshin]]

We could SetRect() on entrance to/exit from nsAbsoluteContainingBlock::Reflow, but that could have other implications

Comment 2

[David Shin[:dshin]]

Note, FinishAndStoreOverflow already does something similar

Comment 3

[David Shin[:dshin]]

Attachment: Bug 1964120: Remove unneeded aConstrainBSize flag in FinishReflowWithAbsoluteFrames and ReflowAbsoluteFrames. r=#anchor-positioning-reviewers,#layout

Comment 4

[David Shin[:dshin]]

Attachment: Bug 1964120: SetRect on abspos container while reflowing its abspos frames. r=#anchor-positioning-reviewers,#layout

Comment 5

[David Shin[:dshin]]

Abandoning this approach, changing the ticket to center on landing D248268

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e87691492f92
Remove unneeded aConstrainBSize flag in FinishReflowWithAbsoluteFrames and ReflowAbsoluteFrames. r=layout-reviewers,emilio

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e87691492f92