Closed Bug 1964295 Opened 1 year ago Closed 1 year ago

regression: TB138 FAILs subscribe to >1 network calendar; wrong credentials passed to backend CalDAV auth

Categories

(Calendar :: Provider: CalDAV, defect)

Product:
Calendar
Component:
Provider: CalDAV
Version:
Thunderbird 138
Type:
defect

Tracking

(thunderbird_esr128 unaffected, thunderbird138+ fixed, thunderbird139 fixed)

Status:
VERIFIED FIXED
Milestone:
140 Branch
Tracking Flags:
Tracking Status
thunderbird_esr128 --- unaffected
thunderbird138 + fixed
thunderbird139 --- fixed

People

(Reporter: pgnd, Assigned: mkmelin)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1964295 - Back out most of bug 1920710 since using multiple CalDAV calendars on same domain with different authentications did not work. r=#thunderbird-reviewers
48 bytes, text/x-phabricator-request
corey
: approval-comm-beta+
corey
: approval-comm-release+
Details | Review

Steps to reproduce:

in TB128esr/upstream i've subscribed to multiple CalDAV calendars, all served by Radicale v3.

works without fail.

after migrating from TB128esr -> TB138release,

    Name: Thunderbird
    Version: 138.0
    Build ID: 20250423163813
    Distribution ID:

    Update Channel: release
    User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:138.0) Gecko/20100101 Firefox/138.0 Thunderbird/138.0
    OS: Linux 6.14.4-300.fc42.x86_64 #1 SMP PREEMPT_DYNAMIC Fri Apr 25 15:43:38 UTC 2025

i can no longer access/create any Network Calendar other than the first.

in a clean TB138 instance, no calendars yet subscribed, on a SUCCESSFUL creation / subscription of the first Network Calendar; entered in the NewCalendar dialog(s) as:

u1: user1@example.com
url1: https://dav.example.net:50443/dav/user1%40example.com/7...xxx/
p1: A...456

Radicale logs the OK transaction

	2025-05-04T20:23:33.494944-04:00 dav radicale[67194]: [67194/Thread-1 (process_request_thread)] [INFO] HEAD request for '/dav/user1@example.com/7...xxx/' received from 127.0.0.1 (forwarded for '192.168.1.14') using 'Mozilla/5.0 (X11; Linux x86_64; rv:138.0) Gecko/20100101 Firefox/138.0 Thunderbird/138.0' TLSv1.3 TLS_CHACHA20_POLY1305_SHA256
	2025-05-04T20:23:33.495313-04:00 dav radicale[67194]: [67194/Thread-1 (process_request_thread)] [INFO] Successful login: 'user1@example.com' (http_x_remote_user)
	2025-05-04T20:23:33.496663-04:00 dav radicale[67194]: [67194/Thread-2 (process_request_thread)] [INFO] PROPFIND request for '/dav/user1@example.com/7...xxx/' with depth '0' received from 127.0.0.1 (forwarded for '192.168.1.14') using 'Mozilla/5.0 (X11; Linux x86_64; rv:138.0) Gecko/20100101 Firefox/138.0 Thunderbird/138.0' TLSv1.3 TLS_CHACHA20_POLY1305_SHA256
	2025-05-04T20:23:33.496742-04:00 dav radicale[67194]: [67194/Thread-2 (process_request_thread)] [INFO] Successful login: 'user1@example.com' (http_x_remote_user)
	2025-05-04T20:23:33.497988-04:00 dav radicale[67194]: [67194/Thread-2 (process_request_thread)] [INFO] PROPFIND response status for '/dav/user1@example.com/7...xxx/' with depth '0' in 0.001 seconds: 207 Multi-Status
	2025-05-04T20:23:33.519631-04:00 dav radicale[67194]: [67194/Thread-1 (process_request_thread)] [INFO] HEAD response status for '/dav/user1@example.com/7...xxx/' in 0.025 seconds: 200 OK
	2025-05-04T20:23:40.435415-04:00 dav radicale[67194]: [67194/Thread-3 (process_request_thread)] [INFO] PROPFIND request for '/dav/user1@example.com/7...xxx/' with depth '0' received from 127.0.0.1 (forwarded for '192.168.1.14') using 'Mozilla/5.0 (X11; Linux x86_64; rv:138.0) Gecko/20100101 Firefox/138.0 Thunderbird/138.0' TLSv1.3 TLS_CHACHA20_POLY1305_SHA256
	2025-05-04T20:23:40.435631-04:00 dav radicale[67194]: [67194/Thread-3 (process_request_thread)] [INFO] Successful login: 'user1@example.com' (http_x_remote_user)
	2025-05-04T20:23:40.444038-04:00 dav radicale[67194]: [67194/Thread-3 (process_request_thread)] [INFO] PROPFIND response status for '/dav/user1@example.com/7...xxx/' with depth '0' in 0.009 seconds: 207 Multi-Status
	2025-05-04T20:23:41.108141-04:00 dav radicale[67194]: [67194/Thread-4 (process_request_thread)] [INFO] OPTIONS request for '/dav/user1@example.com/' received from 127.0.0.1 (forwarded for '192.168.1.14') using 'Mozilla/5.0 (X11; Linux x86_64; rv:138.0) Gecko/20100101 Firefox/138.0 Thunderbird/138.0' TLSv1.3 TLS_CHACHA20_POLY1305_SHA256
	2025-05-04T20:23:41.108212-04:00 dav radicale[67194]: [67194/Thread-4 (process_request_thread)] [INFO] Successful login: 'user1@example.com' (http_x_remote_user)
	2025-05-04T20:23:41.108496-04:00 dav radicale[67194]: [67194/Thread-4 (process_request_thread)] [INFO] OPTIONS response status for '/dav/user1@example.com/' in 0.000 seconds: 200 OK
	2025-05-04T20:23:41.838747-04:00 dav radicale[67194]: [67194/Thread-5 (process_request_thread)] [INFO] REPORT request for '/dav/user1@example.com/7...xxx/' with depth '1' received from 127.0.0.1 (forwarded for '192.168.1.14') using 'Mozilla/5.0 (X11; Linux x86_64; rv:138.0) Gecko/20100101 Firefox/138.0 Thunderbird/138.0' TLSv1.3 TLS_CHACHA20_POLY1305_SHA256
	2025-05-04T20:23:41.838902-04:00 dav radicale[67194]: [67194/Thread-5 (process_request_thread)] [INFO] Successful login: 'user1@example.com' (http_x_remote_user)
	2025-05-04T20:23:41.865895-04:00 dav radicale[67194]: [67194/Thread-5 (process_request_thread)] [INFO] REPORT response status for '/dav/user1@example.com/7...xxx/' with depth '1' in 0.027 seconds: 207 Multi-Status
	2025-05-04T20:23:42.544537-04:00 dav radicale[67194]: [67194/Thread-6 (process_request_thread)] [INFO] REPORT request for '/dav/user1@example.com/7...xxx/' with depth '1' received from 127.0.0.1 (forwarded for '192.168.1.14') using 'Mozilla/5.0 (X11; Linux x86_64; rv:138.0) Gecko/20100101 Firefox/138.0 Thunderbird/138.0' TLSv1.3 TLS_CHACHA20_POLY1305_SHA256
	2025-05-04T20:23:42.544605-04:00 dav radicale[67194]: [67194/Thread-6 (process_request_thread)] [INFO] Successful login: 'user1@example.com' (http_x_remote_user)
	2025-05-04T20:23:42.553589-04:00 dav radicale[67194]: [67194/Thread-6 (process_request_thread)] [INFO] REPORT response status for '/dav/user1@example.com/7...xxx/' with depth '1' in 0.009 seconds: 207 Multi-Status
	2025-05-04T20:23:43.672524-04:00 dav radicale[67194]: [67194/Thread-7 (process_request_thread)] [INFO] REPORT request for '/dav/user1@example.com/7...xxx/' with depth '1' received from 127.0.0.1 (forwarded for '192.168.1.14') using 'Mozilla/5.0 (X11; Linux x86_64; rv:138.0) Gecko/20100101 Firefox/138.0 Thunderbird/138.0' TLSv1.3 TLS_CHACHA20_POLY1305_SHA256
	2025-05-04T20:23:43.672740-04:00 dav radicale[67194]: [67194/Thread-7 (process_request_thread)] [INFO] Successful login: 'user1@example.com' (http_x_remote_user)
	2025-05-04T20:23:43.681367-04:00 dav radicale[67194]: [67194/Thread-7 (process_request_thread)] [INFO] REPORT response status for '/dav/user1@example.com/7...xxx/' with depth '1' in 0.009 seconds: 207 Multi-Status

the subscribed FIRST Calendar is fully visible and usable.

creating the SECOND network calendar, hosted on the same Radicale server, entering the second set of credentials:

u2: user2@example.com
url2: https://dav.example.net:50443/dav/user2%40example.com/f...YYY/
p2: B...123

authentication FAILS, because despite the 2nd username being correctly entered, TBird SUBMITS the FIRST username -- hence, an auth mismatch/fail,

???	2025-05-04T20:31:22.683482-04:00 dav radicale[67194]: [67194/Thread-26 (process_request_thread)] [INFO] Access to '/user2@example.com/f...YYY/' denied for 'user1@example.com'
	2025-05-04T20:31:22.683532-04:00 dav radicale[67194]: [67194/Thread-26 (process_request_thread)] [INFO] PROPFIND response status for '/dav/user2@example.com/f...YYY/' with depth '0' in 0.001 seconds: 403 Forbidden
	2025-05-04T20:31:23.352007-04:00 dav radicale[67194]: [67194/Thread-27 (process_request_thread)] [INFO] GET request for '/dav/user2@example.com/f...YYY/' received from 127.0.0.1 (forwarded for '192.168.1.14') using 'Mozilla/5.0 (X11; Linux x86_64; rv:138.0) Gecko/20100101 Firefox/138.0 Thunderbird/138.0' TLSv1.3 TLS_CHACHA20_POLY1305_SHA256
???	2025-05-04T20:31:23.352398-04:00 dav radicale[67194]: [67194/Thread-27 (process_request_thread)] [INFO] Access to '/user2@example.com/f...YYY/' denied for 'user1@example.com'
	2025-05-04T20:31:23.352445-04:00 dav radicale[67194]: [67194/Thread-27 (process_request_thread)] [INFO] GET response status for '/dav/user2@example.com/f...YYY/' in 0.000 seconds: 403 Forbidden
	2025-05-04T20:31:24.021534-04:00 dav radicale[67194]: [67194/Thread-28 (process_request_thread)] [INFO] PROPFIND request for '/dav/user2@example.com/f...YYY/' with depth '0' received from 127.0.0.1 (forwarded for '192.168.1.14') using 'Mozilla/5.0 (X11; Linux x86_64; rv:138.0) Gecko/20100101 Firefox/138.0 Thunderbird/138.0' TLSv1.3 TLS_CHACHA20_POLY1305_SHA256
???	2025-05-04T20:31:24.021865-04:00 dav radicale[67194]: [67194/Thread-28 (process_request_thread)] [INFO] Access to '/user2@example.com/f...YYY/' denied for 'user1@example.com'
	2025-05-04T20:31:24.021912-04:00 dav radicale[67194]: [67194/Thread-28 (process_request_thread)] [INFO] PROPFIND response status for '/dav/user2@example.com/f...YYY/' with depth '0' in 0.000 seconds: 403 Forbidden

NOTE the access to the correct URL for user 2

	/dav/user2@example.com/f...YYY/

but the WRONG username submitted user 1

	denied for 'user1@example.com'

this is repeatable here on multiple PCs -- all TBird/Linux accessing the same Radicale server.
it always succeeds for first calendar; always fails as above for additional calendars -- specifically always submitting the first calendar's username

drop back to TBird 128esr cures the issue -- all multiple Calendars are subscribable.

Actual results:

can only subscribe to one/first Network calendar.
for 2nd and on, wrong username (first uername!) passed by TBird to CalDAV; authentication fails.

Expected results:

multiple network calendars all subscribed

I can confirm this is a problem. Investigating.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Regressed by: 1920710

same here.
as workaround I created in hosts file a new domain to access the second calendar on server. It looks like the credentials are now host based and then the first one is used everytime

Duplicate of this bug: 1964473
Duplicate of this bug: 1962189
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Duplicate of this bug: 1962038
See Also: → 1959599
status-thunderbird139: --- → affected
Keywords: checkin-needed-tb
Target Milestone: --- → 140 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/c7b4edc62f1d
Back out most of bug 1920710 since using multiple CalDAV calendars on same domain with different authentications did not work. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Comment on attachment 9485516 [details]
Bug 1964295 - Back out most of bug 1920710 since using multiple CalDAV calendars on same domain with different authentications did not work. r=#thunderbird-reviewers

Uplift Approval Request

  • Please state case for uplift consideration and ensure bug severity is set: Regression
  • User impact if declined: May not be able to access calendar
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Daily?: Yes
  • Has the fix been verified in Beta?: No
  • Needs manual test from QA?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Backout
  • String changes made/needed: none
Attachment #9485516 - Flags: approval-comm-release?
Attachment #9485516 - Flags: approval-comm-beta?

Comment on attachment 9485516 [details]
Bug 1964295 - Back out most of bug 1920710 since using multiple CalDAV calendars on same domain with different authentications did not work. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta
Approved for release

Attachment #9485516 - Flags: approval-comm-release?
Attachment #9485516 - Flags: approval-comm-release+
Attachment #9485516 - Flags: approval-comm-beta?
Attachment #9485516 - Flags: approval-comm-beta+

CONFIRMED
up 138.0 -> 139.0b2 does the trick. all/multiple calendars visible and concurrently subscribed, each with unique credentials.
thx o/

Status: RESOLVED → VERIFIED
Duplicate of this bug: 1964991
Duplicate of this bug: 1965267
Duplicate of this bug: 1965429

I'm adding a regression test for this in bug 1901962.

See Also: → 1901962
Duplicate of this bug: 1965753

fyi, not fixed in 138.0.1 release

Duplicate of this bug: 1966223
Duplicate of this bug: 1966686
Duplicate of this bug: 1959599
Duplicate of this bug: 1968455
Duplicate of this bug: 1973951
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: