1901962 - Improve code coverage by implementing new tests

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

I'll use this bug to create tests for sections of code that aren't already covered by tests. This bug replaces bug 1851536, for work after v128.

Comment 1

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1901962 - Refactor opening subdialogs in preferences tests. r=#thunderbird-reviewers

Comment 2

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1901962 - Add new tests which open (almost) all subdialogs in preferences. r=#thunderbird-reviewers

Comment 3

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1901962 - Add tests of the password manager and primary password dialogs. r=#thunderbird-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/67902b555876
Refactor opening subdialogs in preferences tests. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/7120b716ab5f
Add new tests which open (almost) all subdialogs in preferences. r=mkmelin
https://hg.mozilla.org/comm-central/rev/4fbba20af548
Add tests of the password manager and primary password dialogs. r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c419e7fc2d6d
follow-up - Skip test in MSIX builds. r=babolivier

Comment 6

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1901962 follow-up - Skip test in MSIX builds. r=#thunderbird-reviewers

Comment 7

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1901962 - Test message sending scenarios. r=#thunderbird-reviewers

These test sending messages from the compose window with a variety of connection/authentication
problems. They are closely related to the tests named browser_getMessages with the same suffixes.

Sending a message presents a variety of prompt windows to the user, particularly when something
goes wrong. I've tried to avoid writing tests that lock in this behaviour in the hope that one day
somebody will overhaul it.

Comment 8

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1901962 - Fix some nits in the getMessages tests. r=#thunderbird-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/10ad967bf9ab
Test message sending scenarios. r=mkmelin
https://hg.mozilla.org/comm-central/rev/c2c920b05847
Fix some nits in the getMessages tests. r=mkmelin

Comment 10

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1901962 - Test calendar i18n with different OS settings. r=#thunderbird-reviewers

Using environment variables we can pretend the OS date/time settings are different from the default.

These tests check that various labels and styles are applied correctly in different locales:

• Matching the build locale (en-US).
• With the same language but in a different region (en-NZ).
• With very different weekday rules (ar-QA).
• Our most popular non-English locales (de-DE, ja-JP).

These tests only run on Linux.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/61b59ccef666
Test calendar i18n with different OS settings. r=mkmelin

Comment 12

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1901962 - Explicitly test folders with names that require hashing on Windows. r=#thunderbird-back-end-reviewers

I'm going to be working in this area, it would be good to know that I haven't broken it.

Note that I don't think these folder names should require hashing, but they currently do.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dce25e7465d3
Explicitly test folders with names that require hashing on Windows. r=mkmelin

Comment 14

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1901962 - Test the "run junk mail controls" commands. r=#thunderbird-reviewers

Comment 15

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1901962 - Test the many ways to manually mark a message as junk. r=#thunderbird-reviewers

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5c718315560e
Test the "run junk mail controls" commands. r=mkmelin
https://hg.mozilla.org/comm-central/rev/da8e02e4c929
Test the many ways to manually mark a message as junk. r=freaktechnik

Comment 17

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1901962 follow-up - Stop waiting for a mutation that isn't going to happen. r=mkmelin

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3c2812d1291d
follow-up - Stop waiting for a mutation that isn't going to happen. r=mkmelin

Comment 19

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1901962 - Test there can be calendars with different usernames on the same server. r=#thunderbird-reviewers

Most of this patch is upgrading CalDAVServer to authenticate multiple users, and the fallout from that.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b2133e4071f0
Test there can be calendars with different usernames on the same server. r=mkmelin

Comment 21

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Closing this now that ESR 140 has branched.