1964352 - Enable some of the disabled new rules after ktlint 1.5.0 upgrade.

Status: RESOLVED FIXED

(Firefox for Android :: General, task)

Description

[Mihai Adrian Carare [:mcarare]]

We recently upgraded to ktlint version 1.5.0, which introduced some new linting rules. Due to the potential for widespread changes, we initially disabled these new rules in our .editorconfig files.

This issue tracks the work to review and enable a subset of the previously disabled ktlint rules.

Comment 1

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1964352 - Enable standard:colon-spacing ktlint rule and fix errors.

Kotlin style guide: Consistent spacing around colon.

Comment 2

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1964352 - Enable standard:parameter-list-spacing ktlint rule and fix errors.

Kotlin style guide: No new line before parameter type.

Comment 3

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1964352 - Enable standard:try-catch-finally-spacing ktlint rule and fix errors.

Kotlin style guide: Consistent spacing in try { .. } catch { .. } finally { .. }.

Comment 4

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1964352 - Enable standard:property-naming ktlint rule and fix errors.

Kotlin style guide: Constant names use UPPER_SNAKE_CASE, Non-constant names are written in camelCase.

Comment 5

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1964352 - Enable standard:function-naming ktlint rule and fix errors.

Also disable the rule for Composables.

Comment 6

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1964352 - Enable standard:function-literal rule and fix errors.

Kotlin style guide: No newline expected before parameter.

Comment 7

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1964352 - Enable standard:unnecessary-parentheses-before-trailing-lambda rule and fix errors.

Kotlin style guide: No empty parentheses are needed before trailing lambda.

Comment 8

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1964352 - Enable standard:if-else-wrapping and standard:multiline-if-else rules and fix errors.

Kotlin style guide:
Braces are not required for if expressions which have no more than one else branch and which fit on a single line.
When braces are kept for better readability, block should be placed after a new line.

Comment 9

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1964352 - Enable standard:no-wildcard-imports rule and fix errors.

Kotlin style guide: Wildcard imports (of any type) are not allowed.
Also remove exception from detekt for java.util package.

Comment 10

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1964352 - Enable standard:no-single-line-block-comment rule.

Replace single line block comments with EOL comments

Comment 11

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1964352 - Remove duplicate entry for ktlint_standard_no-empty-first-line-in-class-body

Also remove extra blank lines in editorconfig files.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7664711c1f7
Enable standard:colon-spacing ktlint rule and fix errors. r=android-reviewers,nalexander

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b703012d6a24
Enable standard:parameter-list-spacing ktlint rule and fix errors. r=geckoview-reviewers,android-reviewers,nalexander
https://hg.mozilla.org/integration/autoland/rev/356d1ddfca4d
Enable standard:try-catch-finally-spacing ktlint rule and fix errors. r=android-reviewers,nalexander
https://hg.mozilla.org/integration/autoland/rev/e0d52ca653cb
Enable standard:property-naming ktlint rule and fix errors. r=android-reviewers,nalexander,pollymce
https://hg.mozilla.org/integration/autoland/rev/369aea30d300
Enable standard:function-naming  ktlint rule and fix errors. r=android-reviewers,nalexander
https://hg.mozilla.org/integration/autoland/rev/e69ea3203ec1
Enable standard:function-literal rule and fix errors. r=android-reviewers,nalexander
https://hg.mozilla.org/integration/autoland/rev/653c42a0da90
Enable standard:unnecessary-parentheses-before-trailing-lambda rule and fix errors. r=android-reviewers,nalexander
https://hg.mozilla.org/integration/autoland/rev/dce5415cb092
Enable standard:no-wildcard-imports rule and fix errors. r=android-reviewers,nalexander
https://hg.mozilla.org/integration/autoland/rev/8c17555e31e2
Enable standard:no-single-line-block-comment rule. r=android-reviewers,nalexander
https://hg.mozilla.org/integration/autoland/rev/ca73b3cb2304
Remove duplicate entry for ktlint_standard_no-empty-first-line-in-class-body r=android-reviewers,nalexander

Comment 14

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e7664711c1f7
https://hg.mozilla.org/mozilla-central/rev/b703012d6a24
https://hg.mozilla.org/mozilla-central/rev/356d1ddfca4d
https://hg.mozilla.org/mozilla-central/rev/e0d52ca653cb
https://hg.mozilla.org/mozilla-central/rev/369aea30d300
https://hg.mozilla.org/mozilla-central/rev/e69ea3203ec1
https://hg.mozilla.org/mozilla-central/rev/653c42a0da90
https://hg.mozilla.org/mozilla-central/rev/dce5415cb092
https://hg.mozilla.org/mozilla-central/rev/8c17555e31e2
https://hg.mozilla.org/mozilla-central/rev/ca73b3cb2304