1964524 - [M3 migration] Remove the M2 libraries from AC and Fenix/Firefox

Status: VERIFIED FIXED

(Firefox for Android :: Design System and Theming, task, P1)

Description

[Noah Bond [:007]]

After the AC and Firefox code layers have been migrated to M3 and any showstopper migration bugs have been resolved, remove the M2 dependencies/libraries.

Comment 1

[Noah Bond [:007]]

Also - remove the lint exceptions added via https://phabricator.services.mozilla.com/D252225

Comment 2

[Noah Bond [:007]]

Attachment: Bug 1964524 - Part 3 - Remove M2 dependency from Firefox and clean-up temporary linters

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/aabc0afbb86e
https://hg.mozilla.org/integration/autoland/rev/4ed9fa2f435f
Remove M2 dependency from Firefox and clean-up temporary linters r=android-reviewers,npoon

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/91554658a8ca
https://hg.mozilla.org/integration/autoland/rev/dcb944d557a7
Revert "Bug 1964524 - Remove M2 dependency from Firefox and clean-up temporary linters r=android-reviewers,npoon" for causing toolchain failures @ fenix/settings/logins/ui/AddLoginScreen.kt

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing toolchain failures @ fenix/settings/logins/ui/AddLoginScreen.kt

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/dcb944d557a7ac7a5f200e0bbad19d3cfb1ecaf9

Push with failures

Failure log -> fenix/settings/logins/ui/AddLoginScreen.kt

Task :app:compileFenixDebugKotlin
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:16:34 Unresolved reference 'Icon'.
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:16:34: error: Unresolved reference 'Icon'.
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:17:34 Unresolved reference 'Scaffold'.
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:17:34: error: Unresolved reference 'Scaffold'.
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:18:34 Unresolved reference 'Text'.
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:18:34: error: Unresolved reference 'Text'.
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:19:34 Unresolved reference 'TopAppBar'.
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:19:34: error: Unresolved reference 'TopAppBar'.
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:47:5 Unresolved reference 'Scaffold'.
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:47:5: error: Unresolved reference 'Scaffold'.
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:49:13 @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:49:13: error: @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:52:9 Cannot infer type for this parameter. Specify it explicitly.
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:52:9: error: Cannot infer type for this parameter. Specify it explicitly.
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:53:9 @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:53:9: error: @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:56:37 @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:56:37: error: @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:56:49 @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:56:49: error: @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:76:5 Unresolved reference 'TopAppBar'.
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:76:5: error: Unresolved reference 'TopAppBar'.
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:79:13 Unresolved reference 'Text'.
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:79:13: error: Unresolved reference 'Text'.
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:80:24 @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:80:24: error: @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:81:38 @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:81:38: error: @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:86:13 @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:86:13: error: @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:88:56 @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:88:56: error: @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:90:38 @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:90:38: error: @Composable invocations can only happen from the context of a @Composable function
[task 2025-07-01T06:49:11.696+00:00] e: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/AddLoginScreen.kt:94:17 Unresolved reference 'Icon'.

Comment 6

[Noah Bond [:007]]

Fixing this with the next push / lando attempt

Comment 7

[Noah Bond [:007]]

Attachment: Bug 1964524 - Part 1 - Migrate `AddLoginScreen` to M3

Comment 8

[Noah Bond [:007]]

Attachment: Bug 1964524 - Part 2 - Re-apply already-migrated files

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b955839e9927
https://hg.mozilla.org/integration/autoland/rev/250336628099
Part 1 - Migrate `AddLoginScreen` to M3 r=android-reviewers,nalexander
https://github.com/mozilla-firefox/firefox/commit/cf4dbfc9e8f7
https://hg.mozilla.org/integration/autoland/rev/1942cc971ff0
Part 2 - Re-apply already-migrated files r=android-reviewers,calu
https://github.com/mozilla-firefox/firefox/commit/1cc4cf1bd98a
https://hg.mozilla.org/integration/autoland/rev/7e9779790667
Part 3 - Remove M2 dependency from Firefox and clean-up temporary linters r=android-reviewers,npoon

Comment 10

[[e-mail]]

https://hg.mozilla.org/mozilla-central/rev/250336628099
https://hg.mozilla.org/mozilla-central/rev/1942cc971ff0
https://hg.mozilla.org/mozilla-central/rev/7e9779790667

Comment 11

[Noah Bond [:007]]

QE - can you give Firefox some general validation or smoke testing to see if there are any glaring visual defects?

We just migrated to a newer UI library, so some spec changes on components are expected and have been signed-off by UX, such as Buttons becoming rounded and Floating Action Buttons become rounded squares, but we should make sure we didn't miss anything during our design reviews and no features have been accidentally broken as a result of the migration.

Comment 12

[Noah Bond [:007]]

If any defects are found, please file them in the most-relevant component and have them as a blocker for Bug 1813900.

Comment 13

[Mira Lobontiu (Android QA)]

Hi Noah,

QA ran a smoke testing on the latest Firefox for Android Nightly 142.0a1 build from Play Store (from 7/11), and everything looks ok:

• the snackbars were displayed correctly,
• saving pages as bookmarks, or in a collection works as expected,
• installing and removing extensions works as expected,
• downloading files works as expected,
• adding a wallpaper works,
• signing in with an account and syncing works as expected,
• watching videos, or listening to audios work as expected, PiP works as expected,
• searching via the widget, or from the address bar work as expected,
• moving tabs in the tabs tray works,
• private mode works as expected.