1964534 - Use one universal pinned tabs container rather than separate logic for vertical and horizontal

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P1)

Description

[Nikki Sharpley (:nikkis) (she/her)]

For horizontal tabs, pinned tabs are positioned absolutely in the same container as unpinned tabs. For vertical tabs, pinned tabs are in a separate container. We should have one container for both so the same logic and styles apply to vertical and horizontal tabs.

(this helps set us up for success with dragging to pin to an empty state container)

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1964534 - Use one container for both horizontal and vertical pinned tabs r=#tabbrowser-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/397c6bed621e
Use one container for both horizontal and vertical pinned tabs r=desktop-theme-reviewers,sessionstore-reviewers,tabbrowser-reviewers,sidebar-reviewers,kcochrane,sclements,dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d8538c1516a
Revert "Bug 1964534 - Use one container for both horizontal and vertical pinned tabs r=desktop-theme-reviewers,sessionstore-reviewers,tabbrowser-reviewers,sidebar-reviewers,kcochrane,sclements,dao" for causing bc failures at browser_remoteness_flip_on_restore.js

Comment 5

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures

Backout link

Push with failures

Failure log browser_remoteness_flip_on_restore.js
Failure log browser_parsable_css.js

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/786bf4e5dc7b
Use one container for both horizontal and vertical pinned tabs r=desktop-theme-reviewers,sessionstore-reviewers,tabbrowser-reviewers,sidebar-reviewers,kcochrane,sclements,dao

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e8240c23e3c
Revert "Bug 1964534 - Use one container for both horizontal and vertical pinned tabs r=desktop-theme-reviewers,sessionstore-reviewers,tabbrowser-reviewers,sidebar-reviewers,kcochrane,sclements,dao" for causing xpcshell failures in test_sidebar_state.js

Comment 8

[Cristian Tuns]

Backed out for causing xpcshell failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/unit/test_sidebar_state.js | xpcshell return code: 0

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a9c5f5ab34a
Use one container for both horizontal and vertical pinned tabs r=desktop-theme-reviewers,sessionstore-reviewers,tabbrowser-reviewers,sidebar-reviewers,kcochrane,sclements,dao

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2c513b016e3
Revert "Bug 1964534 - Use one container for both horizontal and vertical pinned tabs r=desktop-theme-reviewers,sessionstore-reviewers,tabbrowser-reviewers,sidebar-reviewers,kcochrane,sclements,dao" for causing mochitests failures in browser_tab_groups.js.

Comment 11

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_tab_groups.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups.js | pinned tab should be before the tab group - null == "[object XULElement]" -

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f5c3d10232a
Use one container for both horizontal and vertical pinned tabs r=desktop-theme-reviewers,sessionstore-reviewers,tabbrowser-reviewers,sidebar-reviewers,kcochrane,sclements,dao

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5f5c3d10232a